Missing sources upload when sources are deleted and --cache is used

[finebel]

Hi, when using the newly introduced --cache option, there is an issue in the following scenario:

1. Running crowdin upload sources --branch <...> --cache
2. Deleting the branch in Crowdin
3. Running crowdin upload sources --branch <...> --cache again
4. No sources are uploaded (because locally, they haven't changed)

Is this intendend? I think it would be benficial if in the beginning the CLI would pull the file status/hash from Crowdin to compare it with the local cache and decide whether an upload is required or not.

[andrii-bodnar]

@finebel thanks for reporting this! It looks like we check the cache too early. First, we need to decide if the upload is needed, and then we should check the cache. We will look into this.

[finebel]

Thanks for the info 🙌.

[finebel]

we need to decide if the upload is needed

Based on which criteria are you planning to check this? Whether the branch isn't present at all on Crowdin?

[andrii-bodnar]

We plan to check this based on the list of files in this branch and its presence.

[andrii-bodnar]

Fixed in 4.13.0