TargetType.HEART_RATE constant is incorrect (maps to power zone, not heart rate)

[Om3rr]

Bug

The TargetType class in garminconnect/workout.py has an incorrect constant for heart rate:

class TargetType:
    NO_TARGET = 1
    HEART_RATE = 2  # ← this is wrong
    CADENCE = 3
    SPEED = 4
    POWER = 5
    OPEN = 6

Using TargetType.HEART_RATE (value 2) when building a workout step results in Garmin storing the target as power zone (workoutTargetTypeKey: "power.zone"), not heart rate.

Steps to reproduce

from garminconnect.workout import ExecutableStep, TargetType

step = ExecutableStep(
    stepOrder=1,
    stepType={"stepTypeId": 3, "stepTypeKey": "interval", "displayOrder": 3},
    endCondition={"conditionTypeId": 2, "conditionTypeKey": "time", "displayOrder": 2, "displayable": True},
    endConditionValue=300.0,
    targetType={
        "workoutTargetTypeId": TargetType.HEART_RATE,  # value = 2
        "workoutTargetTypeKey": "heart.rate.zone",
        "displayOrder": 2,
    },
    targetValueOne=120,
    targetValueTwo=150,
)

After uploading and fetching back via get_workout_by_id(), Garmin returns:

"targetType": {
  "workoutTargetTypeId": 2,
  "workoutTargetTypeKey": "power.zone"
}

Fix

Garmin's actual target type ID for heart rate zones is 4, not 2. The correct constants should be:

class TargetType:
    NO_TARGET = 1
    POWER = 2        # power.zone
    CADENCE = 3      # cadence
    HEART_RATE = 4   # heart.rate.zone
    SPEED = 5        # speed.zone
    OPEN = 6         # open

Using workoutTargetTypeId: 4 with workoutTargetTypeKey: "heart.rate.zone" produces the correct result verified by fetching the workout back from the API.

Environment

• garminconnect version: 0.2.40
• Python: 3.14.2

[cyberjunky]

Thanks, will add soon, awaiting fix for auth issues.

[ayazhankadessova]

Analysis & Implementation Plan for Issue #333

Key Finding

The TargetType constants have already been fixed by commit c39ba54 ("Fix workout target type IDs to match Garmin API values"). The current values on disk match the correct Garmin API mapping:

class TargetType:
    NO_TARGET = 1
    POWER = 2        # power.zone
    CADENCE = 3      # cadence
    HEART_RATE = 4   # heart.rate.zone
    SPEED = 5        # speed.zone
    OPEN = 6         # open

Remaining Gap

No regression tests exist to prevent these values from silently drifting again.

Proposed Plan

Create tests/test_workout_constants.py (~25 LOC) with pinning assertions for TargetType, StepType, ConditionType, and SportType constants:

from garminconnect.workout import TargetType, StepType, ConditionType, SportType

def test_target_type_ids():
    """Pin TargetType IDs to match Garmin API values (issue #333)."""
    assert TargetType.NO_TARGET == 1
    assert TargetType.POWER == 2
    assert TargetType.CADENCE == 3
    assert TargetType.HEART_RATE == 4
    assert TargetType.SPEED == 5
    assert TargetType.OPEN == 6

def test_step_type_ids():
    assert StepType.WARMUP == 1
    assert StepType.COOLDOWN == 2
    assert StepType.INTERVAL == 3
    assert StepType.RECOVERY == 4
    assert StepType.REST == 5
    assert StepType.REPEAT == 6

def test_condition_type_ids():
    assert ConditionType.DISTANCE == 1
    assert ConditionType.TIME == 2
    assert ConditionType.CALORIES == 3
    assert ConditionType.HEART_RATE == 4
    assert ConditionType.POWER == 5
    assert ConditionType.ITERATIONS == 7

def test_sport_type_ids():
    assert SportType.RUNNING == 1
    assert SportType.CYCLING == 2
    assert SportType.SWIMMING == 5
    assert SportType.STRENGTH == 4
    assert SportType.HIKING == 3
    assert SportType.WALKING == 9
    assert SportType.OTHER == 8

This ensures any future accidental reordering will fail immediately with a clear value mismatch.

[cyberjunky]

Hi, I have these fail, sure they are correct?

FAILED tests/test_workout_constants.py::test_condition_type_ids - assert 4 == 3
FAILED tests/test_workout_constants.py::test_sport_type_ids - assert 3 == 5

[ayazhankadessova]

@cyberjunky #340 can u see this one ?