Skip to content

Commit 11bed0f

Browse files
committed
Merge branch 'main' of https://github.com/daisy/MathCAT
2 parents 5e9de57 + 316e2aa commit 11bed0f

File tree

2 files changed

+30
-24
lines changed

2 files changed

+30
-24
lines changed

PythonScripts/audit_translations/auditor.py

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -392,10 +392,16 @@ def write(self, issue: dict) -> None:
392392
self.stream.write(json.dumps(issue, ensure_ascii=False) + "\n")
393393

394394

395-
def print_warnings(result: ComparisonResult, file_name: str, verbose: bool = False) -> int:
395+
def print_warnings(
396+
result: ComparisonResult,
397+
file_name: str,
398+
verbose: bool = False,
399+
target_language: str = "tr",
400+
) -> int:
396401
"""Print warnings to console. Returns count of issues found."""
397402
issues = 0
398403
display_name = Path(file_name).as_posix()
404+
target_label = normalize_language(target_language)
399405

400406
has_issues = result.missing_rules or result.untranslated_text or result.extra_rules or result.rule_differences
401407
if not has_issues:
@@ -497,24 +503,24 @@ def add_issue(rule: RuleInfo, issue_type: str, payload: Dict[str, Any]) -> None:
497503
issues += 1
498504
elif issue_type == "extra_rule":
499505
console.print(
500-
f" [dim]•[/] [dim](line {entry['line_tr']} in translation)[/]"
506+
f" [dim]•[/] [dim](line {entry['line_tr']} in {target_label})[/]"
501507
)
502508
issues += 1
503509
elif issue_type == "untranslated_text":
504510
console.print(
505-
f" [dim]•[/] [dim](line {entry['line_tr']} tr)[/] "
511+
f" [dim]•[/] [dim](line {entry['line_tr']} {target_label})[/] "
506512
f"[yellow]\"{escape(entry['text'])}\"[/]"
507513
)
508514
issues += 1
509515
else:
510516
diff: RuleDifference = entry["diff"]
511517
console.print(
512-
f" [dim]•[/] [dim](line {entry['line_en']} en, {entry['line_tr']} tr)[/]"
518+
f" [dim]•[/] [dim](line {entry['line_en']} en, {entry['line_tr']} {target_label})[/]"
513519
)
514520
console.print(f" [dim]{diff.description}[/]")
515521
if verbose:
516522
console.print(f" [green]en:[/] {escape(diff.english_snippet)}")
517-
console.print(f" [red]tr:[/] {escape(diff.translated_snippet)}")
523+
console.print(f" [red]{target_label}:[/] {escape(diff.translated_snippet)}")
518524
issues += 1
519525

520526
return issues
@@ -595,7 +601,7 @@ def audit_language(
595601
has_issues = result.missing_rules or result.untranslated_text or result.extra_rules or result.rule_differences
596602
if output_format == "rich":
597603
if has_issues:
598-
issues = print_warnings(result, file_name, verbose)
604+
issues = print_warnings(result, file_name, verbose, language)
599605
if issues > 0:
600606
files_with_issues += 1
601607
total_issues += issues

PythonScripts/audit_translations/tests/golden/rich/cli_calculus_verbose.golden

Lines changed: 18 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -16,46 +16,46 @@
1616
• (line 4 in English)
1717
• divergence (divergence)
1818
Untranslated Text [3]
19-
• (line 10 tr) "divergence"
20-
• (line 11 tr) "div"
21-
• (line 12 tr) "of"
19+
• (line 10 es) "divergence"
20+
• (line 11 es) "div"
21+
• (line 12 es) "of"
2222
Match Pattern Differences [1]
23-
• (line 22 en, 6 tr)
23+
• (line 22 en, 6 es)
2424
Match pattern differs
2525
en: count(*) = 1
26-
tr: .
26+
es: .
2727
Condition Differences [1]
28-
• (line 25 en, 9 tr)
28+
• (line 25 en, 9 es)
2929
Conditions differ
3030
en: $Verbosity='Terse', not(IsNode(*[1], 'leaf'))
31-
tr: $Verbosity='Verbose', not(IsNode(*[1], 'leaf'))
31+
es: $Verbosity='Verbose', not(IsNode(*[1], 'leaf'))
3232
• curl (curl)
3333
Untranslated Text [1]
34-
• (line 22 tr) "curl of"
34+
• (line 22 es) "curl of"
3535
Match Pattern Differences [1]
36-
• (line 35 en, 20 tr)
36+
• (line 35 en, 20 es)
3737
Match pattern differs
3838
en: count(*) = 1
39-
tr: .
39+
es: .
4040
Condition Differences [1]
41-
• (line 39 en, 24 tr)
41+
• (line 39 en, 24 es)
4242
Conditions differ
4343
en: $Verbosity!='Terse', not(IsNode(*[1], 'leaf'))
44-
tr: not(IsNode(*[1], 'leaf'))
44+
es: not(IsNode(*[1], 'leaf'))
4545
Structure Differences [1]
46-
• (line 38 en, 18 tr)
46+
• (line 38 en, 18 es)
4747
Rule structure differs (test/if/then/else blocks)
4848
en: replace: test: if: then: test: if: then:
49-
tr: replace: test: if: then:
49+
es: replace: test: if: then:
5050
• gradient (gradient)
5151
Untranslated Text [2]
52-
• (line 34 tr) "gradient of"
53-
• (line 35 tr) "del"
52+
• (line 34 es) "gradient of"
53+
• (line 35 es) "del"
5454
Match Pattern Differences [1]
55-
• (line 48 en, 30 tr)
55+
• (line 48 en, 30 es)
5656
Match pattern differs
5757
en: count(*) = 1
58-
tr: .
58+
es: .
5959
╭──────────────────────────────────────────────────────────────────────────────╮
6060
│ SUMMARY │
6161
│ Files checked 1 │

0 commit comments

Comments
 (0)