inline unnecessary IssueWriter class

Author: moritz-gross

PythonScripts/audit_translations/auditor.py

@@ -5,6 +5,7 @@
 and for performing full language audits.
 """
 
+import json
 import sys
 from pathlib import Path
 from typing import List, Optional, TextIO, Tuple
@@ -14,7 +15,7 @@
 
 from .dataclasses import RuleInfo, ComparisonResult
 from .parsers import parse_yaml_file, diff_rules
-from .renderer import IssueWriter, collect_issues, console, print_warnings
+from .renderer import collect_issues, console, print_warnings
 
 # Re-export console so existing `from .auditor import console` callers keep working.
 __all__ = ["console"]
@@ -192,8 +193,6 @@ def audit_language(
     if output_path:
         out_stream = open(output_path, "w", encoding="utf-8", newline="")
 
-    writer = IssueWriter(output_format, out_stream) if output_format != "rich" else None
-
     total_issues = 0
     total_missing = 0
     total_untranslated = 0
@@ -231,7 +230,7 @@ def audit_language(
         else:
             issues_list = collect_issues(result, file_name, language)
             for issue in issues_list:
-                writer.write(issue)
+                out_stream.write(json.dumps(issue, ensure_ascii=False) + "\n")
             if issues_list:
                 files_with_issues += 1
                 total_issues += len(issues_list)

PythonScripts/audit_translations/renderer.py

@@ -7,7 +7,7 @@
 
 import json
 from pathlib import Path
-from typing import Any, Dict, List, TextIO, Tuple
+from typing import Any, Dict, List, Tuple
 
 from rich.console import Console
 from rich.markup import escape
@@ -157,16 +157,6 @@ def collect_issues(
     return issues
 
 
-class IssueWriter:
-    def __init__(self, output_format: str, stream: TextIO):
-        if output_format != "jsonl":
-            raise ValueError(f"Unsupported output format: {output_format}")
-        self.stream = stream
-
-    def write(self, issue: dict) -> None:
-        self.stream.write(json.dumps(issue, ensure_ascii=False) + "\n")
-
-
 def print_warnings(
     result: ComparisonResult,
     file_name: str,

PythonScripts/audit_translations/tests/test_output_jsonl.py

@@ -5,7 +5,7 @@
 from pathlib import Path
 
 from ..auditor import compare_files
-from ..renderer import IssueWriter, collect_issues
+from ..renderer import collect_issues
 
 
 def load_jsonl(text: str) -> list[dict]:
@@ -27,16 +27,14 @@ def test_jsonl_output_matches_golden():
     files = sorted(path.name for path in english_dir.glob("*.yaml"))
 
     stream = StringIO()
-    writer = IssueWriter("jsonl", stream)
 
     for file_name in files:
         result = compare_files(
             str(english_dir / file_name),
             str(translated_dir / file_name),
         )
-        issues = collect_issues(result, file_name, "de")
-        for issue in issues:
-            writer.write(issue)
+        for issue in collect_issues(result, file_name, "de"):
+            stream.write(json.dumps(issue, ensure_ascii=False) + "\n")
 
     actual = load_jsonl(stream.getvalue())