Skip to content

Commit ef1dbb3

Browse files
committed
bump(version): to v0.0.16
1 parent d233da7 commit ef1dbb3

31 files changed

Lines changed: 133 additions & 117 deletions

File tree

.github/workflows/static.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ jobs:
6060
with:
6161
go-version: ${{ env.GO_VERSION }}
6262
- name: golangci-lint
63-
uses: golangci/golangci-lint-action@v3
63+
uses: golangci/golangci-lint-action@v8
6464
with:
6565
working-directory: ${{ matrix.submodules }}
6666
- name: Install olric

.golangci.yml

Lines changed: 12 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,12 @@
1-
run:
2-
go: '1.22.2'
3-
4-
output:
5-
formats:
6-
- format: json
7-
path: stderr
8-
- format: checkstyle
9-
path: report.xml
10-
- format: colored-line-number
1+
version: "2"
112

123
linters:
13-
enable-all: true
4+
default: all
5+
settings:
6+
wsl_v5:
7+
allow-first-in-block: true
8+
allow-whole-block: false
9+
branch-max-lines: 2
1410
disable:
1511
- bodyclose
1612
- containedctx
@@ -23,14 +19,16 @@ linters:
2319
- gochecknoglobals
2420
- gocognit
2521
- gomoddirectives
26-
- gomnd
22+
# - gomnd
2723
- interfacebloat
2824
- ireturn
2925
- lll
3026
- mnd
3127
- nestif
28+
- noinlineerr
3229
- nonamedreturns
3330
- paralleltest
34-
- stylecheck
31+
# - stylecheck
3532
- revive
36-
- wrapcheck
33+
- wrapcheck
34+
- wsl

badger/badger.go

Lines changed: 13 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ import (
2323
// Badger provider type.
2424
type Badger struct {
2525
*badger.DB
26+
2627
stale time.Duration
2728
logger core.Logger
2829
}
@@ -37,7 +38,7 @@ type badgerLogger struct {
3738
}
3839

3940
func (b *badgerLogger) Warningf(msg string, params ...interface{}) {
40-
b.SugaredLogger.Warnf(msg, params...)
41+
b.Warnf(msg, params...)
4142
}
4243

4344
// Factory function create new Badger instance.
@@ -48,6 +49,7 @@ func Factory(badgerConfiguration core.CacheProvider, logger core.Logger, stale t
4849

4950
if badgerConfiguration.Configuration != nil {
5051
var parsedBadger badger.Options
52+
5153
if b, e := json.Marshal(badgerConfiguration.Configuration); e == nil {
5254
if e = json.Unmarshal(b, &parsedBadger); e != nil {
5355
logger.Error("Impossible to parse the configuration for the default provider (Badger)", e)
@@ -112,7 +114,7 @@ func (provider *Badger) Uuid() string {
112114
func (provider *Badger) MapKeys(prefix string) map[string]string {
113115
keys := map[string]string{}
114116

115-
_ = provider.DB.View(func(txn *badger.Txn) error {
117+
_ = provider.View(func(txn *badger.Txn) error {
116118
opts := badger.DefaultIteratorOptions
117119
opts.PrefetchValues = false
118120
iterator := txn.NewIterator(opts)
@@ -139,7 +141,7 @@ func (provider *Badger) MapKeys(prefix string) map[string]string {
139141
func (provider *Badger) ListKeys() []string {
140142
keys := []string{}
141143

142-
err := provider.DB.View(func(txn *badger.Txn) error {
144+
err := provider.View(func(txn *badger.Txn) error {
143145
opts := badger.DefaultIteratorOptions
144146
opts.PrefetchValues = false
145147
it := txn.NewIterator(opts)
@@ -174,7 +176,7 @@ func (provider *Badger) Get(key string) []byte {
174176

175177
var result []byte
176178

177-
err := provider.DB.View(func(txn *badger.Txn) error {
179+
err := provider.View(func(txn *badger.Txn) error {
178180
i, err := txn.Get([]byte(key))
179181
item = i
180182

@@ -198,7 +200,7 @@ func (provider *Badger) Get(key string) []byte {
198200

199201
// GetMultiLevel tries to load the key and check if one of linked keys is a fresh/stale candidate.
200202
func (provider *Badger) GetMultiLevel(key string, req *http.Request, validator *core.Revalidator) (fresh *http.Response, stale *http.Response) {
201-
_ = provider.DB.View(func(tx *badger.Txn) error {
203+
_ = provider.View(func(tx *badger.Txn) error {
202204
result, err := tx.Get([]byte(core.MappingKeyPrefix + key))
203205
if err != nil && !errors.Is(err, badger.ErrKeyNotFound) {
204206
return err
@@ -226,7 +228,7 @@ func (provider *Badger) GetMultiLevel(key string, req *http.Request, validator *
226228
func (provider *Badger) SetMultiLevel(baseKey, variedKey string, value []byte, variedHeaders http.Header, etag string, duration time.Duration, realKey string) error {
227229
now := time.Now()
228230

229-
err := provider.DB.Update(func(btx *badger.Txn) error {
231+
err := provider.Update(func(btx *badger.Txn) error {
230232
var err error
231233

232234
compressed := new(bytes.Buffer)
@@ -280,7 +282,7 @@ func (provider *Badger) SetMultiLevel(baseKey, variedKey string, value []byte, v
280282

281283
// Set method will store the response in Badger provider.
282284
func (provider *Badger) Set(key string, value []byte, duration time.Duration) error {
283-
err := provider.DB.Update(func(txn *badger.Txn) error {
285+
err := provider.Update(func(txn *badger.Txn) error {
284286
return txn.SetEntry(badger.NewEntry([]byte(key), value).WithTTL(duration))
285287
})
286288
if err != nil {
@@ -292,20 +294,19 @@ func (provider *Badger) Set(key string, value []byte, duration time.Duration) er
292294

293295
// Delete method will delete the response in Badger provider if exists corresponding to key param.
294296
func (provider *Badger) Delete(key string) {
295-
_ = provider.DB.Update(func(txn *badger.Txn) error {
297+
_ = provider.Update(func(txn *badger.Txn) error {
296298
return txn.Delete([]byte(key))
297299
})
298300
}
299301

300302
// DeleteMany method will delete the responses in Badger provider if exists corresponding to the regex key param.
301303
func (provider *Badger) DeleteMany(key string) {
302304
rgKey, e := regexp.Compile(key)
303-
304305
if e != nil {
305306
return
306307
}
307308

308-
_ = provider.DB.View(func(txn *badger.Txn) error {
309+
_ = provider.View(func(txn *badger.Txn) error {
309310
opts := badger.DefaultIteratorOptions
310311
opts.PrefetchValues = false
311312
it := txn.NewIterator(opts)
@@ -330,13 +331,11 @@ func (provider *Badger) Init() error {
330331

331332
// Reset method will reset or close provider.
332333
func (provider *Badger) Reset() error {
333-
err := provider.DB.DropAll()
334-
if err != nil {
334+
if err := provider.DropAll(); err != nil {
335335
provider.logger.Errorf("Impossible to reset the Badger DB, %v", err)
336336
}
337337

338-
err = provider.DB.Close()
339-
if err != nil {
338+
if err := provider.Close(); err != nil {
340339
provider.logger.Errorf("Impossible to close the Badger DB, %v", err)
341340
}
342341

badger/caddy/go.mod

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@ go 1.23.0
44

55
require (
66
github.com/caddyserver/caddy/v2 v2.8.4
7-
github.com/darkweak/storages/badger v0.0.15
8-
github.com/darkweak/storages/core v0.0.15
7+
github.com/darkweak/storages/badger v0.0.16
8+
github.com/darkweak/storages/core v0.0.16
99
)
1010

1111
require (

badger/go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ go 1.23.0
44

55
require (
66
dario.cat/mergo v1.0.1
7-
github.com/darkweak/storages/core v0.0.15
7+
github.com/darkweak/storages/core v0.0.16
88
github.com/dgraph-io/badger/v4 v4.8.0
99
github.com/pierrec/lz4/v4 v4.1.22
1010
go.uber.org/zap v1.27.0

core/registered.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@ func ResetRegisteredStorages() {
3131
_ = value.(Storer).Reset()
3232
}
3333
}
34+
3435
registered.Delete(key)
3536

3637
return true

etcd/caddy/go.mod

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@ go 1.22.1
44

55
require (
66
github.com/caddyserver/caddy/v2 v2.8.4
7-
github.com/darkweak/storages/core v0.0.15
8-
github.com/darkweak/storages/etcd v0.0.15
7+
github.com/darkweak/storages/core v0.0.16
8+
github.com/darkweak/storages/etcd v0.0.16
99
)
1010

1111
require (

etcd/etcd.go

Lines changed: 12 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ import (
2121
// Etcd provider type.
2222
type Etcd struct {
2323
*clientv3.Client
24+
2425
stale time.Duration
2526
ctx context.Context
2627
logger core.Logger
@@ -61,10 +62,8 @@ func Factory(etcdCfg core.CacheProvider, logger core.Logger, stale time.Duration
6162
return nil, err
6263
}
6364

64-
for {
65-
if cli.ActiveConnection().GetState() == connectivity.Ready {
66-
break
67-
}
65+
for cli.ActiveConnection().GetState() != connectivity.Ready {
66+
6867
}
6968

7069
return &Etcd{
@@ -85,9 +84,9 @@ func (provider *Etcd) Name() string {
8584
func (provider *Etcd) Uuid() string {
8685
return fmt.Sprintf(
8786
"%s-%s-%s-%s",
88-
strings.Join(provider.Client.Endpoints(), ","),
89-
provider.Client.Username,
90-
provider.Client.Password,
87+
strings.Join(provider.Endpoints(), ","),
88+
provider.Username,
89+
provider.Password,
9190
provider.stale,
9291
)
9392
}
@@ -103,7 +102,6 @@ func (provider *Etcd) ListKeys() []string {
103102
keys := []string{}
104103

105104
result, e := provider.Client.Get(provider.ctx, core.MappingKeyPrefix, clientv3.WithPrefix())
106-
107105
if e != nil {
108106
if !provider.reconnecting {
109107
go provider.Reconnect()
@@ -225,9 +223,9 @@ func (provider *Etcd) SetMultiLevel(baseKey, variedKey string, value []byte, var
225223
return err
226224
}
227225

228-
rs, err := provider.Client.Grant(context.TODO(), int64(duration.Seconds()))
226+
rs, err := provider.Grant(context.TODO(), int64(duration.Seconds()))
229227
if err == nil {
230-
_, err = provider.Client.Put(provider.ctx, variedKey, compressed.String(), clientv3.WithLease(rs.ID))
228+
_, err = provider.Put(provider.ctx, variedKey, compressed.String(), clientv3.WithLease(rs.ID))
231229
}
232230

233231
if err != nil {
@@ -242,8 +240,8 @@ func (provider *Etcd) SetMultiLevel(baseKey, variedKey string, value []byte, var
242240

243241
mappingKey := core.MappingKeyPrefix + baseKey
244242
result := provider.Get(mappingKey)
245-
val, e := core.MappingUpdater(variedKey, result, provider.logger, now, now.Add(duration), now.Add(duration+provider.stale), variedHeaders, etag, realKey)
246243

244+
val, e := core.MappingUpdater(variedKey, result, provider.logger, now, now.Add(duration), now.Add(duration+provider.stale), variedHeaders, etag, realKey)
247245
if e != nil {
248246
return e
249247
}
@@ -263,9 +261,9 @@ func (provider *Etcd) Set(key string, value []byte, duration time.Duration) erro
263261
return fmt.Errorf("the connection is not ready: %v", provider.Client.ActiveConnection().GetState())
264262
}
265263

266-
rs, err := provider.Client.Grant(context.TODO(), int64(duration.Seconds()))
264+
rs, err := provider.Grant(context.TODO(), int64(duration.Seconds()))
267265
if err == nil {
268-
_, err = provider.Client.Put(provider.ctx, key, string(value), clientv3.WithLease(rs.ID))
266+
_, err = provider.Put(provider.ctx, key, string(value), clientv3.WithLease(rs.ID))
269267
}
270268

271269
if err != nil {
@@ -299,7 +297,6 @@ func (provider *Etcd) DeleteMany(key string) {
299297
}
300298

301299
rgKey, e := regexp.Compile(key)
302-
303300
if e != nil {
304301
return
305302
}
@@ -321,7 +318,7 @@ func (provider *Etcd) Init() error {
321318

322319
// Reset method will reset or close provider.
323320
func (provider *Etcd) Reset() error {
324-
return provider.Client.Close()
321+
return provider.Close()
325322
}
326323

327324
func (provider *Etcd) Reconnect() {

etcd/etcd_test.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@ func TestEtcdConnectionFactory(t *testing.T) {
3636
go asyncCheck()
3737

3838
instance, err := getEtcdInstance()
39+
3940
checker <- true
4041

4142
if nil != err {

etcd/go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ go 1.22.1
55
replace github.com/darkweak/storages/core => ../core
66

77
require (
8-
github.com/darkweak/storages/core v0.0.15
8+
github.com/darkweak/storages/core v0.0.16
99
github.com/pierrec/lz4/v4 v4.1.22
1010
go.etcd.io/etcd/client/v3 v3.5.18
1111
go.uber.org/zap v1.27.0

0 commit comments

Comments
 (0)