Skip to content

Commit 2c10e3f

Browse files
authored
Typos and tweaks (#1876)
1 parent 40395c1 commit 2c10e3f

4 files changed

Lines changed: 8 additions & 7 deletions

File tree

src/main/java/net/datafaker/idnumbers/HungarianIdNumber.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -64,12 +64,12 @@ private String basePart(BaseProviders faker, LocalDate birthday, PersonIdNumber.
6464

6565
static int getCheckDigit(String basePart) {
6666
char[] numbers = basePart.toCharArray();
67-
int summ = 0;
67+
int sum = 0;
6868
for (int i = 0; i < numbers.length; i++) {
69-
summ += getNumericValue(numbers[i]) * (i + 1);
69+
sum += getNumericValue(numbers[i]) * (i + 1);
7070
}
7171

72-
return summ % 11;
72+
return sum % 11;
7373
}
7474

7575
static int firstDigit(int birthYear, PersonIdNumber.Gender gender) {

src/main/java/net/datafaker/idnumbers/IdNumberGenerator.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ default String generateValid(BaseProviders faker) {
2727
String generateInvalid(BaseProviders faker);
2828

2929
/**
30-
* Generates a valid ID number for given country corresponding to given criterias (age range, gender etc.)
30+
* Generates a valid ID number for the given country that matches the specified criteria (age range, gender, etc.)
3131
*
3232
* @return PersonIdNumber containing a valid combination of ID, Birthday and Gender.
3333
* In countries where ID number doesn't contain gender and/or birthday, the latter values are just random.

src/main/java/net/datafaker/providers/base/Barcode.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,10 +54,11 @@ private long ean(int length) {
5454
int i = 0;
5555
while (number > 0) {
5656
i++;
57+
int digit = (int) (number % 10);
5758
if (i % 2 == 1) {
58-
odd += number % 10;
59+
odd += digit;
5960
} else {
60-
even += number % 10;
61+
even += digit;
6162
}
6263

6364
number /= 10;

src/main/java/net/datafaker/providers/base/Lorem.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@ public String sentence(int wordCount) {
113113
public String sentence(int wordCount, int randomWordsToAdd) {
114114
int numberOfWordsToAdd = randomWordsToAdd == 0 ? 0 : faker.random().nextInt(randomWordsToAdd);
115115
final int totalWordCount = wordCount + numberOfWordsToAdd;
116-
StringBuilder sb = new StringBuilder();
116+
StringBuilder sb = new StringBuilder(totalWordCount * 8);
117117
if (totalWordCount > 0) {
118118
sb.append(capitalizeWords(word()));
119119
}

0 commit comments

Comments
 (0)