Suggestion: change the package name and the project name the same one

[bom-d-van]

It's helpful if everyone using the package can use the same name to refer to its contents, which implies that the package name should be good: short, concise, evocative. By convention, packages are given lower case, single-word names; there should be no need for underscores or mixedCaps.

http://golang.org/doc/effective_go.html#package-names

It's mostly a problem of taste, but changing the project name into mapset or even changing both the project name and the package name into something like goset or something else would be wonderfully nice. Because it's simply recommend by the Go authors. :D

[deckarep]

Actually,

You are right about this: I'll take care of it.

On Apr 28, 2014, at 6:53 AM, bom_d_van notifications@github.com wrote:

It's helpful if everyone using the package can use the same name to refer to its contents, which implies that the package name should be good: short, concise, evocative. By convention, packages are given lower case, single-word names; there should be no need for underscores or mixedCaps.

http://golang.org/doc/effective_go.html#package-names

It's mostly a problem of taste, but changing the project name into mapset or even changing both the project name and the package name into something like goset or something else would be wonderfully nice. Because it's simply recommend by the Go authors. :D

—
Reply to this email directly or view it on GitHub.

[jeffwidman]

@deckarep Given that the generics issue is a fairly big release that you're already planning to do as a v2 release, would it make sense to include this rename / URL update as well?

I think goset probably makes the most sense, as it retains some of the SEO benefit of golang-set compared to mapset. Renaming the repo URL should work okay, since GitHub will add a 301 redirect as long as you never create a new golang-set repo which would break that 301.