Skip to content

Commit 89e9adb

Browse files
authored
Hotfix (#59)
* introduce mesh builder trait * remove old construction traits * split builder into two * use bufwriter properly * refactor mesh writer, add obj writer * improve read error handling * update examples * add script for running all examples * update readme * format * fix wasm build * fix readme and obj reading bug
1 parent 4dcce51 commit 89e9adb

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -47,14 +47,14 @@ For more control, you can use format-specific readers and writers directly:
4747
use baby_shark::io::{StlReader, StlWriter, ObjReader};
4848

4949
// Using specific readers
50-
let mut stl_reader = StlReader::new();
50+
let mut stl_reader = StlReader::default();
5151
let mesh = stl_reader.read_from_file(Path::new("./mesh.stl"))?;
5252

53-
let mut obj_reader = ObjReader::new();
53+
let mut obj_reader = ObjReader::default();
5454
let mesh = obj_reader.read_from_file(Path::new("./mesh.obj"))?;
5555

5656
// Using specific writers
57-
let stl_writer = StlWriter::new();
57+
let stl_writer = StlWriter::default();
5858
stl_writer.write_to_file(&mesh, Path::new("./output.stl"))?;
5959
```
6060

src/io/obj.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -134,6 +134,6 @@ fn parse_face<'a>(mut parts: impl Iterator<Item = &'a str>) -> Option<Statement>
134134
}
135135

136136
fn parse_vertex_idx_from_face_stmt(stmt: &str) -> Option<usize> {
137-
let (vertex_idx_str, _) = stmt.split_once('/')?;
137+
let (vertex_idx_str, _) = stmt.split_once('/').unwrap_or((stmt, ""));
138138
vertex_idx_str.parse::<usize>().map(|idx| idx - 1).ok() // obj indices are 1-based
139139
}

0 commit comments

Comments
 (0)