Skip to content

Banning with delete_message_seconds doesn't ensure there are no recent messages by user (still happens) #8360

Description

@RiskyMH

Description

Basically #8243 isn't fully solved yet sadly. While it is better, it overall is actually worse because my double softbanning doesn't solve this new issue. I'm not sure on the reproduction steps this time as it doesn't work in isolation but there is a seemingly growing chance that it will leave a message behind.

This is across different bots and many servers that I've seen this reported. Sorry that I couldn't provide a more useful repo - but this has been reported to me many times and I think it would be best if discord could re look at the logic and improve it again!

Considering that the double banning option (even after some seconds) doesn't work anymore, it leads me to think it's a different kind of race condition but still a bad one.

Thanks again @brad-discord for fixing the main more often issue!

Steps to Reproduce

Ban member with delete_message_seconds

Expected Behavior

No messages left within that time

Current Behavior

A chance that the most recent message stays - albeit a small chance, still a significant one

Screenshots/Videos

No response

Client and System Information

n/a

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugsyncedSynced to internal tracker

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions