Log viewer requires `:result` key and does not accept `java.time.Instant` as `:time`

[Ramblurr]

I was trying to turn telemere signals into maps that were suitable for display with :portal.viewer/log and ran in to several problems:

1. The :result key is required, even the the predicate spec doesn't list it, if you do not pass it the viewer breaks.
2. The :time predicate is inst?, which java.time.Instant passes. But if you pass a java.time.Instant as :time, the viewer breaks.

By "breaks" I mean the viewer falls back to the inspector viewer, I never actually saw any error messages.

Here is a working config I landed on:

(require '[taoensso.telemere :as taoensso.telemere])
(defn telemere->tap
  ([{:keys [msg_ level inst] :as signal}]
   (tap>
    (with-meta
      (->
       ;; remove a bunch of nil values
       (into {} (remove #(nil? (val %))) signal)
       ;; add result which the portal viewer will use to display the log message
       (assoc :result [level msg_])
       ;; viewer doesn't support java.time.Instant
       (assoc :time (java.util.Date/from inst))
       (dissoc :inst)
       ;; telemere provides ns as a string, but viewer wants a symbol
       (update :ns  symbol)
       ;; add in runtime to get a nice logo
       (assoc :runtime ((requiring-resolve 'portal.console/runtime))))
      {:portal.viewer/default :portal.viewer/log
       :portal.viewer/for
       {:form :portal.viewer/pprint
        :time :portal.viewer/relative-time}})))
  ([]
   (tap> [:signal "telemere handler has shut down"])))

(defn add-telemere-tap-handler! []
  (taoensso.telemere/remove-handler! :tap-handler)
  (taoensso.telemere/add-handler! :tap-handler telemere->tap
                                                       {:min-level :debug}))

(do
  (add-telemere-tap-handler!)
  (taoensso.telemere/log! {:level :error :data {:err "Exception"}} "Error oh noes!")
  (taoensso.telemere/log! {:level :info :data {:interesting :fact}} "Did you know that..")
  (taoensso.telemere/log! {:level :debug :data {:data [42]}} "datadatatatadatatatata"))

Screenshots

[djblue]

Hi @Ramblurr, thanks for sharing your experience. I have updated the spec to better reflect the viewers expectations: 500352b.

I think the main issue with java.time.Instant is that portal doesn't treat it as a first class citizen (only java.util.Date and js/Date). I think once this is improved in Portal, the viewer could support alternative DateTime types.