"Done" notifications in dash vs github web

[bodograumann]

I am a bit confused about how the "done" status works here.
With the default filter "is:notification" I am seeing lots of notifications that I already marked as "Done" in GitHub web.
Does dash track the state separately?
Also, is it possible to see Done notifications in dash?

[dlvhdr]

@sideshowbarker knows better than me here

[bodograumann]

I have had the agent have a look through the code and it seems to be like this:

• When marking notifications as Done in gh-dash, this is propagated to GitHub via a DELETE call, but
• additionally gh-dash remembers the notification in its internal doneStore.
• The default query uses all = true and thus includes even Done notifications,
• but the ones from the doneStore are then filtered client-side.

I'll look into whether the query can be improved to leave out Done items, but maybe that isn't possible and that is where the doneStore was introduced.

Update:
Yes, the GitHub api currently doesn't support filtering by Done state...
Upvote here: https://github.com/orgs/community/discussions/50224

[sideshowbarker]

All correct. But also worth explicitly noting for the record here: dash’s done.json only tracks notifications you mark Done inside dash. It’s got no way to know what you mark Done in the GitHub web UI — given that GH doesn’t expose those Done actions through the GH Notifications API (so we have no way to make dash sync those).

That’s kind of the whole cause: With the default config (includeReadNotifications: true), dash fetches with all=true. And so, GH returns your web-Done-marked notifications alongside the read ones, and dash’s client-side filter only hides what’s in its own store — which web-Done’d items were never added to. (Ones you mark Done within dash do stay hidden across sessions.)

So if you mostly manage Done state from the web UI, you probably want set the following at the top level of your config:

includeReadNotifications: false