codecleanup

Author: drivardxrm

TimePicker/ControlManifest.Input.xml

@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="utf-8" ?>
 <manifest>
-  <control namespace="DR" constructor="TimePicker" version="1.0.8" display-name-key="TimePicker" description-key="TimePicker control based on React time Picker (rc-time-picker)" control-type="standard" preview-image="img/timepicker-preview.png"> 
+  <control namespace="DR" constructor="TimePicker" version="1.0.9" display-name-key="TimePicker" description-key="TimePicker control based on React time Picker (rc-time-picker)" control-type="standard" preview-image="img/timepicker-preview.png"> 
     <!-- property node identifies a specific, configurable piece of data that the control expects from CDS -->
     <property name="hourvalue" display-name-key="Hour Value Field" description-key="Bind this property to the field where you want to store the hour value" of-type="Whole.None" usage="bound" required="true" />
     <property name="minutevalue" display-name-key="Minute Value Field" description-key="Bind this property to the field where you want to store the minute value" of-type="Whole.None" usage="bound" required="true" />

TimePicker/TimePickerTextBox.tsx

@@ -37,15 +37,15 @@ const TimePickerTextBox = (props : IProps): JSX.Element => {
 
         if(props.hourvalue !== undefined && props.minutevalue !== undefined) 
         {
-            //console.log("EFFECT [props.hourvalue, props.minutevalue] : setTimevalue " + props.hourvalue + ":" + props.minutevalue);
+            
             let newTimevalue:Moment = moment().hour(props.hourvalue).minute(props.minutevalue);
             if(newTimevalue !== timevalue)
             {
                 setTimevalue(newTimevalue);
             }
 
         }else{
-            //console.log("EFFECT [props.hourvalue, props.minutevalue] : setTimevalue undefined");
+            
             setTimevalue(undefined);
         }
     }, [props.hourvalue, props.minutevalue]);

TimePicker/index.ts

@@ -50,30 +50,21 @@ export class TimePicker implements ComponentFramework.StandardControl<IInputs, I
 	 */
 	public updateView(context: ComponentFramework.Context<IInputs>): void
 	{
-		//Visibility of the main attribute on the form
-		let isVisible = context.mode.isVisible 
-		
+
 		// If the bound attribute is disabled because it is inactive or the user doesn't have access
 		let isReadOnly = context.mode.isControlDisabled;
 
 		let isMasked = false;
 		// When a field has FLS enabled, the security property on the attribute parameter is set
 		if (context.parameters.hourvalue.security) {
-			isReadOnly = isReadOnly || !context.parameters.hourvalue.security.editable;
-			isVisible = isVisible && context.parameters.hourvalue.security.readable;
-			isMasked = isVisible && !context.parameters.hourvalue.security.readable
+			isReadOnly = isReadOnly || !context.parameters.hourvalue.security.editable;		
+			isMasked = !context.parameters.hourvalue.security.readable
 		}
 
-		if(!isVisible){
-			return;
-		}
-		
-		
-		
 		//Prepare props for component rendering
 		this._hourvalue = context.parameters.hourvalue.raw !== null ? context.parameters.hourvalue.raw : undefined;
 		this._minutevalue = context.parameters.minutevalue.raw !== null ? context.parameters.minutevalue.raw : undefined;
-		console.log("before render : " + this._hourvalue + ":" + this._minutevalue + ", props "+ this._props.hourvalue + ":" + this._props.minutevalue);
+		
 		//RENDER ONLY IF DIFFERENT
 		if(this.shouldRender())
 		{
@@ -119,7 +110,7 @@ export class TimePicker implements ComponentFramework.StandardControl<IInputs, I
 
 	//Function called when props is signaling an update
 	private notifyChange(hourvalue:number|undefined, minutevalue:number|undefined) {
-		console.log("notifyChange : " + hourvalue + ":" + minutevalue);
+		
 		this._hourvalue = hourvalue;
 		this._minutevalue = minutevalue;
 		this._notifyOutputChanged();  //=> will trigger getOutputs