Merge pull request #971 from dyoshikawa/fix/improve-e2e-test-robustness

fix: improve e2e test robustness with stderr diagnostics and safe cleanup default

Author: dyoshikawa

src/e2e/e2e-helper.ts

@@ -67,7 +67,8 @@ export async function runGenerate({
  */
 export function useTestDirectory(): { getTestDir: () => string } {
   let testDir = "";
-  let cleanup: () => Promise<void>;
+  // oxlint-disable-next-line unicorn/consistent-function-scoping -- default avoids undefined if beforeEach fails
+  let cleanup: () => Promise<void> = async () => {};
 
   beforeEach(async () => {
     ({ testDir, cleanup } = await setupTestDirectory());

src/e2e/e2e-mcp.spec.ts

@@ -53,10 +53,12 @@ describe("E2E: mcp", () => {
     });
 
     let hasError = false;
+    let stderrOutput = "";
 
     // Collect stderr output and check for actual errors
     mcpProcess.stderr?.on("data", (data) => {
       const output = data.toString();
+      stderrOutput += output;
       // Check if the output contains actual error messages (not just warnings)
       if (output.toLowerCase().includes("error") && !output.includes("warning")) {
         hasError = true;
@@ -75,6 +77,6 @@ describe("E2E: mcp", () => {
     });
 
     // Verify that there were no actual errors (warnings are acceptable)
-    expect(hasError).toBe(false);
+    expect(hasError, `MCP daemon produced errors: ${stderrOutput}`).toBe(false);
   });
 });