Ignore files in .gitignore

[vrevelas]

It would be nice if the plugin ignored files that match patterns in .gitignore by default. I currently have to add new directories (e.g. node_modules) to both .gitignore and to the plugin's in my pom.xml.

[dwalluck]

I've submitted #53 which allows a single file to be used for exclude patterns. There are many ignore-type files (not just .gitignore) and .gitignore can appear in any directory which is more complicated to deal with.

Still, this is hopefully enough for you as you can set <excludesFile>.gitignore</excludesFile>.

[ppalaga]

+1 for adding an option to exclude files ignored by git.

I'd prefer an implementation based on a proper .gitignore parser and proper evaluation of the patterns as documented in https://git-scm.com/docs/gitignore . JGit might contain all we need and I would not mind having a non-optional JGit dependency because of this.

The proposal in #53 does not meet the above requirement.

[dwalluck]

@ppalaga I recently noticed that, in a multi-module project, the exlcudesFile parameter is failing if the file does not exist in every module. This looks to be my fault. Either we should modify the option not to fail if the file is missing, or have a single file for the entire project. Something like .gitignore may appear in other directories, but it certainly is not required. Appologies if I should not have reported this on this ticket.

[ppalaga]

Yeah, please open a new ticket. A fix is welcome!

[StefanD986]

Another idea would be to only format scm tracked files. That I think would be easier to implement because then you can just rely on the maven-scm-plugin to get the list of files tracked by the scm.

The other advantage of that would be that its not only git specific. (While git is probably the most used scm nowadays I'd say there are still a fair amount of non-git tracked projects out there)

[FibreFoX]

@StefanD986 There is a problem when relying on tracked files only, because I would need to add these files before running this plugin. In my workflow I tend to git add files after I created several lines. It would result in having a "everything is fine" due to my new files not being tracked yet, but after having them added, the plugin would tell me "omg, what have you done". I would want to have this feedback faster.

So I would advocate to have .gitignore being one source file for this filtering, instead of relying on current tracked state.

[ppalaga]

In #156 I propose to introduce an SPI for additional excludes. Ignoring patterns in .gitignore could be another implementation of that SPI. Contributions are welcome.