GLSP-1634: Switch to eslint 9.x (#42)

Part of eclipse-glsp/glsp/issues/1634

Author: tortmayr

.eslintignore

@@ -16,3 +16,8 @@ examples/workflow-test/playwright/.storage/*.json
 *.vsix
 !*.env.example
 *.env
+
+./claude/settings.local.json
+.claude/plans
+.reviews
+CLAUDE.local.md

.eslintrc.js

@@ -0,0 +1,51 @@
+# Repository Guidelines
+
+## Project Structure & Module Organization
+
+This repository is a Yarn workspaces monorepo.
+
+-   `packages/glsp-playwright/`: core library source (`src/`) and build output (`lib/`).
+-   `examples/workflow-test/`: runnable Playwright example with page objects in `src/` and tests in `tests/`.
+-   `docs/`: concept docs (`integration`, `extension`, `metadata`, and Playwright differences).
+-   Root config files (`tsconfig.json`, `eslint.config.mjs`, `lerna.json`) define shared tooling.
+
+Use `packages/*` for reusable framework code and `examples/*` for integration demos and test fixtures.
+
+## Build, Test, and Development Commands
+
+Run from repository root unless noted.
+
+-   `yarn install`: install all workspace dependencies.
+-   `yarn build`: compile TypeScript project references and rewrite path aliases.
+-   `yarn lint`: run ESLint across the monorepo.
+-   `yarn format` / `yarn format:check`: apply/check Prettier formatting.
+-   `yarn test`: run example Playwright suite (`examples/workflow-test`).
+-   `yarn test:standalone`, `yarn test:theia`, `yarn test:vscode`: run integration-specific test projects.
+-   `yarn watch`: watch and rebuild TypeScript + alias output during development.
+
+## Coding Style & Naming Conventions
+
+-   Language: TypeScript (`.ts`), 4-space indentation (follow existing files).
+-   Formatting: Prettier via `@eclipse-glsp/prettier-config`.
+-   Linting: ESLint (`eslint.config.mjs`) with strict TypeScript rules (for example, no floating promises).
+-   Naming patterns:
+    -   Tests: `*.spec.ts` under `examples/workflow-test/tests/**`.
+    -   Page objects/helpers: `*.po.ts`, `*.capability.ts`, `*.integration.ts`.
+    -   Keep feature folders aligned with GLSP feature names (`tool-palette`, `validation`, `undo-redo`, etc.).
+
+## Testing Guidelines
+
+Tests use Playwright (`@playwright/test`) and run from compiled output (`examples/workflow-test/lib/tests`).
+
+-   Build before testing when sources changed: `yarn build`.
+-   Prefer targeted runs during development, then run `yarn test` before opening a PR.
+-   Keep tests deterministic and cover standalone, Theia, and VS Code paths when relevant.
+
+## Commit & Pull Request Guidelines
+
+Commit history favors short, imperative subjects, often with issue IDs (example: `GLSP-1563: Update to node 20 and Theia 1.64.x`).
+
+-   Reference related issue IDs in commit/PR text when available.
+-   PRs should fill all template sections in `.github/PULL_REQUEST_TEMPLATE.md`:
+    `What it does`, `How to test`, `Follow-ups`, and `Changelog` impact.
+-   Do not disclose vulnerabilities in issues/PRs; follow `SECURITY.md`.

.gitignore

@@ -0,0 +1 @@
+@AGENTS.md

AGENTS.md

@@ -0,0 +1,46 @@
+import glspConfig from '@eclipse-glsp/eslint-config';
+
+export default [
+    ...glspConfig,
+    {
+        ignores: ['**/*.js', '**/*.mjs', '**/*.cjs', '**/dist/', '**/lib/', '**/repositories/', '**/*.map']
+    },
+    {
+        files: ['**/*.{ts,tsx}'],
+        languageOptions: {
+            parserOptions: {
+                project: './tsconfig.eslint.json',
+                tsconfigRootDir: import.meta.dirname
+            }
+        },
+        rules: {
+            '@typescript-eslint/no-floating-promises': 'error',
+            'no-null/no-null': 'off',
+            'no-restricted-imports': [
+                'error',
+                {
+                    paths: [
+                        {
+                            name: 'sprotty',
+                            message:
+                                "The sprotty default exports are customized and reexported by GLSP. Please use '@eclipse-glsp/client' instead"
+                        },
+                        {
+                            name: 'sprotty-protocol',
+                            message:
+                                "The sprotty default exports are customized and reexported by GLSP. Please use '@eclipse-glsp/client' instead"
+                        }
+                    ],
+                    patterns: ['**/../index']
+                }
+            ]
+        },
+        settings: {
+            'import-x/resolver': {
+                typescript: {
+                    project: 'tsconfig.json'
+                }
+            }
+        }
+    }
+];

CLAUDE.md

@@ -34,7 +34,7 @@
   "scripts": {
     "build": "tsc -b",
     "clean": "rimraf --glob lib tsconfig.tsbuildinfo server/*.log",
-    "lint": "eslint --ext .ts,.tsx ./src ./tests",
+    "lint": "eslint ./src ./tests",
     "prepare": "playwright install",
     "repo": "ts-node  ./scripts/repositories.ts",
     "start:server": "node node_modules/@eclipse-glsp-examples/workflow-server-bundled/wf-glsp-server-node.js",

eslint.config.mjs

@@ -1,5 +1,5 @@
 /********************************************************************************
- * Copyright (c) 2024-2025 EclipseSource and others.
+ * Copyright (c) 2024-2026 EclipseSource and others.
  *
  * This program and the accompanying materials are made available under the
  * terms of the Eclipse Public License v. 2.0 which is available at
@@ -13,7 +13,6 @@
  *
  * SPDX-License-Identifier: EPL-2.0 OR GPL-2.0 WITH Classpath-exception-2.0
  ********************************************************************************/
-/* eslint-disable max-len */
 
 import { expect, extractDebugInformationOfGLSPLocator, extractMetaTree, test } from '@eclipse-glsp/glsp-playwright/';
 import { WorkflowApp } from '../../src/app/workflow-app';

examples/workflow-test/package.json

@@ -12,20 +12,21 @@
     ]
   },
   "scripts": {
-    "all": "yarn clean && yarn install && yarn lint",
     "build": "yarn compile && yarn compile:alias",
-    "check:headers": "glsp checkHeaders . -t lastCommit",
-    "check:pr": "yarn all && yarn format:checkyarn && check:headers",
+    "check:all": "yarn install && yarn lint && yarn format:check && yarn headers:check",
     "clean": "lerna run clean",
     "compile": "tsc -b",
     "compile:alias": "lerna run compile:alias",
     "example": "yarn -s --cwd ./examples/workflow-test",
+    "fix:all": "yarn lint:fix && yarn format && yarn headers:fix",
     "format": "prettier --write .",
     "format:check": "prettier --check .",
-    "generate:index": "lerna run generate:index  && yarn lint:fix",
-    "lint": "eslint --ext .ts,.tsx .",
+    "generate:index": "lerna run generate:index && yarn lint:fix",
+    "headers:check": "glsp checkHeaders .",
+    "headers:fix": "glsp checkHeaders . --autoFix",
+    "lint": "eslint .",
     "lint:ci": "yarn lint --output-file eslint_report.json --format json",
-    "lint:fix": " yarn lint --fix",
+    "lint:fix": "yarn lint --fix",
     "prepare": "lerna run prepare && yarn build",
     "publish:latest": "lerna publish from-package --no-git-reset -y",
     "publish:next": "lerna publish preminor --exact --canary --preid next --dist-tag next --no-git-tag-version --no-push --ignore-scripts --yes",
@@ -43,7 +44,6 @@
     "@estruyf/github-actions-reporter": "^1.7.0",
     "@types/node": "20.x",
     "concurrently": "^8.2.2",
-    "eslint-import-resolver-typescript": "^3.5.3",
     "lerna": "^9.0.0",
     "mocha-ctrf-json-reporter": "0.0.9",
     "tsc-alias": "1.8.10",