-
Notifications
You must be signed in to change notification settings - Fork 3
Open
Labels
good first issueGood for newcomersGood for newcomers
Description
When we create a VM app instance for an app that has no ports, we will fail to create one, due to lack of StaticUri on the App:
| if app.InternalPorts || len(ports) == 0 { |
Since when we create load balancer VM for the VM App, we expect there to be staticUri in order to name the VM, but in this case it's empty:
| orchVals.lbName = appInst.StaticUri |
To fix, we should disallow a creation of an VM App without any ports, or not create a load balancer VM in case there are no public ports(though we need to think about the reason behind such app.)
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
good first issueGood for newcomersGood for newcomers