indent_size ignored in json-mode

[dustinpaluch]

Reproduce:

1. emacs -q
2. package-initialize
3. Create a new directory with editorconfig:

root = true

[*]
indent_style = space
indent_size = 2
charset = utf-8
trim_trailing_whitespace = true
insert_final_newline = true

4. Create a json file with:

{
  "test": 1
}

5. editorconfig-apply
6. editorconfig-display-current-properties yields

# EditorConfig for /Users/dustinpaluch/src/editorconfig-test/test.json
indent_style = space
indent_size = 2
charset = utf-8
trim_trailing_whitespace = true
insert_final_newline = true

7. Hit tab with point on the line with "test"

Expected:

I expect the line to have two spaces of indentation

Actual:

I get four spaces of indentation

[jizhang]

If you're using Emacs 30, JSON files use js-json-mode that does not derive from js-mode any more, so the editorconfig-indentation-alist variable needs to be updated. For example, in your init.el:

(use-package editorconfig
  :init (editorconfig-mode 1)
  :config
  (add-to-list 'editorconfig-indentation-alist
               '(js-json-mode js-indent-level))
  :delight)

I've opened a pull request #372

[cswank]

I'm having the same issue on emacs 30 and the above solution does not help. I also use json-mode and not js-json-mode. I also tried

(use-package editorconfig
  :init (editorconfig-mode 1)
  :config
  (add-to-list 'editorconfig-indentation-alist
               '(js-json-mode js-indent-level json-mode))
  :delight)

and

(use-package editorconfig
  :init (editorconfig-mode 1)
  :config
  (add-to-list 'editorconfig-indentation-alist
               '(json-mode))
  :delight)

But do not get the indentation specified in my .editorconfig file.

My .editorconfig:

# EditorConfig is awesome: https://editorconfig.org

# top-most EditorConfig file
root = true

[**.json]
indent_style = space
indent_size = 10
trim_trailing_whitespace = true

(using 10 spaces just for testing)

[monnier]

The code you used is wrong, I think you need something like:

(add-to-list 'editorconfig-indentation-alist '(json-mode json-mode-indent-level))

But of course, you shouldn't need it.
I pushed a patch to json-mode so it will work out of the box in the next version of json-mode.

[cswank]

Thanks for the suggestions, but I can't get it to work with your solution (I tried several permutations of it). Your fix does work if I switch to js-json-mode, but that mode is so ugly, haha. I'll just wait for the official fix to come out.

[monnier]

I tested

/usr/bin/emacs -Q -l .../json-mode-autoloads.el -f editorconfig-mode --eval '(add-to-list `editorconfig-indentation-alist `(json-mode json-mode-indent-level))' ~/tmp/editorconfig/foo.json

before sending the previous comment, so it should definitely work (with Emacs-30), but of course, it depends on various other things (e.g. it will signal an error if you run it before editorconfig is loaded, so better do (editorconfig-mode 1) beforehand, which will inevitably load editorconfig).

[cswank]

I got it working. I don't know what happened but after restarting emacs its working.