Skip to content

Errors are swallowed when signing with custom hook #49

@henryliu-git

Description

@henryliu-git

If I sign with normal flow and if there is any error, it will throw and the tool/script using windows-sign can terminate early and exit with exit code 1.

However if I use custom hook function and I throw error in the custom function, it seems windows-sign will log the error but without re-throwing the error. So the tool/script using it doesn't know there is an error with signing and exit with exit code 0.

It should re-throw the error here:
https://github.com/electron/windows-sign/blob/main/src/sign-with-hook.ts#L44

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions