State: Use Resource.emit_changed() not changed.emit() (#2367)

State: Use Resource.emit_changed() not changed.emit()

These are almost completely equivalent, except when a resource is being
loaded, but I believe emit_changed() is better practice.

Author: wjt

scenes/globals/game_state/global_state.gd

@@ -37,7 +37,7 @@ signal helper_changed
 			else:
 				push_warning("Ignoring unknown inventory item type: %s" % type_name)
 		inventory = items
-		changed.emit()
+		emit_changed()
 
 ## [Quest]s which the player has previously completed. Modify this with
 ## [method set_quest_completed_state].
@@ -63,7 +63,7 @@ signal helper_changed
 				push_warning("Ignoring unknown quest in save file: %s" % path)
 		completed_quests = quests
 		completed_quests_changed.emit()
-		changed.emit()
+		emit_changed()
 
 ## Global player state. During a quest, [member QuestState.player] should be
 ## used instead. [GameState.player] always points to the correct instance.
@@ -82,15 +82,15 @@ func _validate_property(property: Dictionary) -> void:
 func add_collected_item(item: InventoryItem) -> void:
 	inventory.append(item)
 	item_collected.emit(item)
-	changed.emit()
+	emit_changed()
 
 
 ## Remove all [InventoryItem]s from the [member inventory].
 func clear_inventory() -> void:
 	for item: InventoryItem in inventory.duplicate():
 		inventory.erase(item)
 		item_consumed.emit(item)
-	changed.emit()
+	emit_changed()
 
 
 ## Updates [member completed_quests] to include [param quest] if [param
@@ -101,12 +101,12 @@ func set_quest_completed_state(quest: Quest, is_completed: bool) -> void:
 		if quest not in completed_quests:
 			completed_quests.append(quest)
 			completed_quests_changed.emit()
-			changed.emit()
+			emit_changed()
 	else:
 		while quest in completed_quests:
 			completed_quests.erase(quest)
 			completed_quests_changed.emit()
-			changed.emit()
+			emit_changed()
 
 
 ## Obtain the help from a townie, for using it later in the game.

scenes/globals/game_state/per_scene_state.gd

@@ -43,4 +43,4 @@ func set_lights_on(new_value: bool, immediate: bool = false) -> void:
 
 func set_spawn_point(new_value: NodePath) -> void:
 	spawn_point = new_value
-	changed.emit()
+	emit_changed()

scenes/globals/game_state/player_state.gd

@@ -13,14 +13,14 @@ const MAX_LIVES := 2 ** 53
 @export_range(0, MAX_LIVES, 1) var lives: int = MAX_LIVES:
 	set(value):
 		lives = value
-		changed.emit()
+		emit_changed()
 
 ## Bitfield of elements of Enums.PlayerAbilities
 @export var abilities: int:
 	set(value):
 		if abilities != value:
 			abilities = value
-			changed.emit()
+			emit_changed()
 			abilities_changed.emit()
 
 

scenes/globals/game_state/quest_state.gd

@@ -62,4 +62,4 @@ func get_challenge_start_scene() -> String:
 
 func set_challenge_start_scene(value: String) -> void:
 	challenge_start_scene = ResourceUID.ensure_path(value)
-	changed.emit()
+	emit_changed()