Many warnings and errors during export

[wjt]

Testing #2347 via Remote Deploy → Run in Browser I saw the following export warnings:

WARNING: Can't save Callables.
     at: write_variant (core/io/resource_format_binary.cpp:1896)
WARNING: Can't save Callables.
     at: write_variant (core/io/resource_format_binary.cpp:1896)
WARNING: Can't save Callables.
     at: write_variant (core/io/resource_format_binary.cpp:1896)
WARNING: Can't save Callables.
     at: write_variant (core/io/resource_format_binary.cpp:1896)
WARNING: Can't save Callables.
     at: write_variant (core/io/resource_format_binary.cpp:1896)
WARNING: Can't save Callables.
     at: write_variant (core/io/resource_format_binary.cpp:1896)
WARNING: Depth of field blur is only available when using the Forward+ or Mobile renderer.
     at: camera_attributes_set_dof_blur (servers/rendering/storage/camera_attributes_storage.cpp:70)
WARNING: Can't save Callables.
     at: write_variant (core/io/resource_format_binary.cpp:1896)
WARNING: Can't save Callables.
     at: write_variant (core/io/resource_format_binary.cpp:1896)
WARNING: Can't save Callables.
     at: write_variant (core/io/resource_format_binary.cpp:1896)
WARNING: Can't save Callables.
     at: write_variant (core/io/resource_format_binary.cpp:1896)
WARNING: Can't save Callables.
     at: write_variant (core/io/resource_format_binary.cpp:1896)
SCRIPT ERROR: Invalid access to property or key 'quest' on a base object of type 'Node (game_state.gd)'.
          at: _update_ability_name (res://scenes/game_elements/props/powerup/components/powerup.gd:65)
          GDScript backtrace (most recent call first):
              [0] _update_ability_name (res://scenes/game_elements/props/powerup/components/powerup.gd:65)
              [1] _set_ability (res://scenes/game_elements/props/powerup/components/powerup.gd:43)
SCRIPT ERROR: Invalid assignment of property or key 'action' with value of type 'String' on a base object of type 'Nil'.
          at: _set_ability (res://scenes/game_elements/props/powerup/components/powerup.gd:44)
          GDScript backtrace (most recent call first):
              [0] _set_ability (res://scenes/game_elements/props/powerup/components/powerup.gd:44)
SCRIPT ERROR: Invalid access to property or key 'quest' on a base object of type 'Node (game_state.gd)'.
          at: _update_ability_name (res://scenes/game_elements/props/powerup/components/powerup.gd:65)
          GDScript backtrace (most recent call first):
              [0] _update_ability_name (res://scenes/game_elements/props/powerup/components/powerup.gd:65)
              [1] _set_ability (res://scenes/game_elements/props/powerup/components/powerup.gd:43)
SCRIPT ERROR: Invalid assignment of property or key 'action' with value of type 'String' on a base object of type 'Nil'.
          at: _set_ability (res://scenes/game_elements/props/powerup/components/powerup.gd:44)
          GDScript backtrace (most recent call first):
              [0] _set_ability (res://scenes/game_elements/props/powerup/components/powerup.gd:44)
SCRIPT ERROR: Invalid access to property or key 'quest' on a base object of type 'Node (game_state.gd)'.
          at: _update_ability_name (res://scenes/game_elements/props/powerup/components/powerup.gd:65)
          GDScript backtrace (most recent call first):
              [0] _update_ability_name (res://scenes/game_elements/props/powerup/components/powerup.gd:65)
              [1] _set_ability (res://scenes/game_elements/props/powerup/components/powerup.gd:43)
SCRIPT ERROR: Invalid assignment of property or key 'action' with value of type 'String' on a base object of type 'Nil'.
          at: _set_ability (res://scenes/game_elements/props/powerup/components/powerup.gd:44)
          GDScript backtrace (most recent call first):
              [0] _set_ability (res://scenes/game_elements/props/powerup/components/powerup.gd:44)
SCRIPT ERROR: Invalid access to property or key 'quest' on a base object of type 'Node (game_state.gd)'.
          at: _update_ability_name (res://scenes/game_elements/props/powerup/components/powerup.gd:65)
          GDScript backtrace (most recent call first):
              [0] _update_ability_name (res://scenes/game_elements/props/powerup/components/powerup.gd:65)
              [1] _set_ability (res://scenes/game_elements/props/powerup/components/powerup.gd:43)
SCRIPT ERROR: Invalid assignment of property or key 'action' with value of type 'String' on a base object of type 'Nil'.
          at: _set_ability (res://scenes/game_elements/props/powerup/components/powerup.gd:44)
          GDScript backtrace (most recent call first):
              [0] _set_ability (res://scenes/game_elements/props/powerup/components/powerup.gd:44)
WARNING: Parent path './PlayersContainer/charlie/PlayerInteraction/InteractMarker' for node 'InteractLabel' has vanished when instantiating: 'res://scenes/quests/story_quests/after_the_tremor/3_combat/after_the_tremor_combat.tscn'.
     at: instantiate (scene/resources/packed_scene.cpp:211)
WARNING: res://scenes/quests/story_quests/after_the_tremor/3_combat/after_the_tremor_combat.tscn: A node in the scene this one inherits from has been removed or moved, so a recovery process needs to take place. Please re-save this scene to avoid the cost of this process next time.
     at: instantiate (scene/resources/packed_scene.cpp:290)
WARNING: Node './InteractLabel' was modified from inside an instance, but it has vanished.
     at: instantiate (scene/resources/packed_scene.cpp:310)
WARNING: Parent path './PlayersContainer/bryan/PlayerInteraction/InteractMarker/InteractLabel' for node 'LabelContainer' has vanished when instantiating: 'res://scenes/quests/story_quests/after_the_tremor/3_combat/after_the_tremor_combat.tscn'.
     at: instantiate (scene/resources/packed_scene.cpp:211)
WARNING: Node './LabelContainer' was modified from inside an instance, but it has vanished.
     at: instantiate (scene/resources/packed_scene.cpp:310)
ERROR: The Image width specified (0 pixels) must be greater than 0 pixels.
   at: initialize_data (core/io/image.cpp:2389)
ERROR: Invalid image: image is empty
   at: create_from_image (scene/resources/image_texture.cpp:58)
ERROR: The Image width specified (0 pixels) must be greater than 0 pixels.
   at: initialize_data (core/io/image.cpp:2389)
ERROR: Invalid image: image is empty
   at: create_from_image (scene/resources/image_texture.cpp:58)

This is as of commit 9d37b03.

[wjt]

A good chunk of these are coming from example files in Phantom Camera:

WARNING: Can't save Callables.
     at: write_variant (core/io/resource_format_binary.cpp:1896)
[   3% ] savepack | Storing File: res://.godot/exported/133200997/export-c62cbc003e6d001c9233df9ff61acb0b-3d_example_scene.scn
Loading resource: res://addons/phantom_camera/examples/example_scenes/3D/3d_follow_framed_example_scene.tscn
WARNING: Can't save Callables.
     at: write_variant (core/io/resource_format_binary.cpp:1896)
[   3% ] savepack | Storing File: res://.godot/exported/133200997/export-80c4f64f8cf14ce8324da8e697f94e3e-3d_follow_framed_example_scene.scn
Loading resource: res://addons/phantom_camera/examples/example_scenes/3D/3d_follow_glued_example_scene.tscn
WARNING: Can't save Callables.
     at: write_variant (core/io/resource_format_binary.cpp:1896)
[   3% ] savepack | Storing File: res://.godot/exported/133200997/export-d1ffda3949a07661af2c9023fae9453a-3d_follow_glued_example_scene.scn
Loading resource: res://addons/phantom_camera/examples/example_scenes/3D/3d_follow_group_example_scene.tscn
WARNING: Can't save Callables.
     at: write_variant (core/io/resource_format_binary.cpp:1896)
[   3% ] savepack | Storing File: res://.godot/exported/133200997/export-56cae865500e4e3433b561f156da2b89-3d_follow_group_example_scene.scn
Loading resource: res://addons/phantom_camera/examples/example_scenes/3D/3d_follow_path_example_scene.tscn
Loading resource: res://addons/phantom_camera/examples/scripts/3D/path_follow.gd
WARNING: Can't save Callables.
     at: write_variant (core/io/resource_format_binary.cpp:1896)
[   3% ] savepack | Storing File: res://.godot/exported/133200997/export-c40558e57541b907cdb9e69a07516353-3d_follow_path_example_scene.scn
Loading resource: res://addons/phantom_camera/examples/example_scenes/3D/3d_follow_simple_example_scene.tscn
WARNING: Can't save Callables.
     at: write_variant (core/io/resource_format_binary.cpp:1896)
[   3% ] savepack | Storing File: res://.godot/exported/133200997/export-9db9eb4a5b03dc5a848a3999d6c0640b-3d_follow_simple_example_scene.scn
Loading resource: res://addons/phantom_camera/examples/example_scenes/3D/3d_follow_third_person_attribtues_example_scene.tscn
Loading resource: res://addons/phantom_camera/examples/example_scenes/3D/sub_scenes/playable_character_third_person_3d.tscn
Loading resource: res://addons/phantom_camera/examples/textures/3D/target.png
Loading resource: res://.godot/imported/target.png-878c5e8d057c8a9a4c2322d4ab88e9ef.s3tc.ctex
WARNING: Depth of field blur is only available when using the Forward+ or Mobile renderer.
     at: camera_attributes_set_dof_blur (servers/rendering/storage/camera_attributes_storage.cpp:70)
WARNING: Can't save Callables.
     at: write_variant (core/io/resource_format_binary.cpp:1896)
[   3% ] savepack | Storing File: res://.godot/exported/133200997/export-3fb5b8f85b64cdb5ca47bba68d2abcfd-3d_follow_third_person_attribtues_example_scene.scn
Loading resource: res://addons/phantom_camera/examples/example_scenes/3D/3d_follow_third_person_example_scene.tscn
WARNING: Can't save Callables.
     at: write_variant (core/io/resource_format_binary.cpp:1896)
[   3% ] savepack | Storing File: res://.godot/exported/133200997/export-8bf71f7584000cfc9868561cad911f09-3d_follow_third_person_example_scene.scn
Loading resource: res://addons/phantom_camera/examples/example_scenes/3D/3d_look_at_example_scene.tscn
WARNING: Can't save Callables.
     at: write_variant (core/io/resource_format_binary.cpp:1896)
[   3% ] savepack | Storing File: res://.godot/exported/133200997/export-1b1850f34814455670d444e0ac10e5b7-3d_look_at_example_scene.scn
Loading resource: res://addons/phantom_camera/examples/example_scenes/3D/3d_noise_example_scene.tscn
Loading resource: res://addons/phantom_camera/examples/scripts/3D/player_controller_first_person.gd
WARNING: Can't save Callables.
     at: write_variant (core/io/resource_format_binary.cpp:1896)
[   3% ] savepack | Storing File: res://.godot/exported/133200997/export-6e6406e844e5e21b7327ead0c84b1990-3d_noise_example_scene.scn
Loading resource: res://addons/phantom_camera/examples/example_scenes/3D/3d_tweening_example_scene.tscn
WARNING: Can't save Callables.
     at: write_variant (core/io/resource_format_binary.cpp:1896)
[   3% ] savepack | Storing File: res://.godot/exported/133200997/export-5c386e81f6bd58720405c78d8cb5ff6c-3d_tweening_example_scene.scn
Loading resource: res://addons/phantom_camera/examples/models/3d_cube_dark.tscn
[   3% ] savepack | Storing File: res://.godot/exported/133200997/export-a8d646126033ffe2ca92b6f07cce9a06-3d_cube_dark.scn
Loading resource: res://addons/phantom_camera/examples/resources/tween/fixed_camera_tween.tres
[   3% ] savepack | Storing File: res://.godot/exported/133200997/export-4275ab4c478878a02650cb52f081a57e-fixed_camera_tween.res
Loading resource: res://addons/phantom_camera/examples/resources/tween/inventory_phantom_camera_2d_tween.tres
[   3% ] savepack | Storing File: res://.godot/exported/133200997/export-c2c117fb1e48e91e4598c180c7650b51-inventory_phantom_camera_2d_tween.res
Loading resource: res://addons/phantom_camera/examples/resources/tween/item_focus_phantom_camera_2d_tween.tres
[   3% ] savepack | Storing File: res://.godot/exported/133200997/export-36d165b4b9756845ffca628479efd044-item_focus_phantom_camera_2d_tween.res
Loading resource: res://addons/phantom_camera/examples/resources/tween/player_phantom_camera_2d_tween.tres
[   3% ] savepack | Storing File: res://.godot/exported/133200997/export-2c5a5bf1fa2f5ad71729061dc549c804-player_phantom_camera_2d_tween.res
Loading resource: res://addons/phantom_camera/examples/resources/tween/player_phantom_camera_3d_tween.tres
[   3% ] savepack | Storing File: res://.godot/exported/133200997/export-370c50c450768ecb81055b1e1474c613-player_phantom_camera_3d_tween.res

[wjt]

[node name="PlayerPhantomCamera3D" type="Node3D" parent="Player" node_paths=PackedStringArray("follow_target")]
unique_name_in_owner = true
transform = Transform3D(0.99995, 0, 0, 0, 0.79324, 0.608671, 0, -0.608675, 0.793235, 0, 2.934684, 3.17294)
top_level = true
script = ExtResource("2_5cpe8")
follow_mode = 5
follow_target = NodePath("../PlayerCharacterBody3D")
tween_resource = ExtResource("3_422w7")
tween_on_load = false
camera_3d_resource = SubResource("Resource_wg1pr")
follow_damping = true
follow_distance = 4.0
dead_zone_width = 0.139
dead_zone_height = 0.14
show_viewfinder_in_play = true
spring_length = 4.0
align_transform_with_view = Callable()
align_position_with_view = Callable()

Well, I guess that explains the "Can't save Callables" errors. ^

[wjt]

SCRIPT ERROR: Invalid access to property or key 'quest' on a base object of type 'Node (game_state.gd)'.
          at: _update_ability_name (res://scenes/game_elements/props/powerup/components/powerup.gd:65)
          GDScript backtrace (most recent call first):
              [0] _update_ability_name (res://scenes/game_elements/props/powerup/components/powerup.gd:65)
              [1] _set_ability (res://scenes/game_elements/props/powerup/components/powerup.gd:43)
SCRIPT ERROR: Invalid assignment of property or key 'action' with value of type 'String' on a base object of type 'Nil'.
          at: _set_ability (res://scenes/game_elements/props/powerup/components/powerup.gd:44)
          GDScript backtrace (most recent call first):
              [0] _set_ability (res://scenes/game_elements/props/powerup/components/powerup.gd:44)

The issue here is that since commit 7bac32c we have a @tool script powerup.gd calling into a non-@tool (GameState) and behaving differently as a result. I think that's wrong because while in the editor the player is never in a quest. I think we can guard more of this behind Engine.is_editor_hint().

[wjt]

I think all these problems are covered by:

• Powerup: Don't access GameState in editor or before _ready #2359
• PlayerMode: Don't access GameState before _ready() #2360
• Phantom Camera: Filter exported files #2361
• after_the_tremor_combat: Update for removal of InteractMarker/InteractLabel from player #2363