New name issues after updating

[Bigmack3000]

Hey, after the latest update, i think there's an issue with artist names when there are multiple album artists. It's taking that name for the first listed artist and making it their full name for everything. Here's some screenshots:

You can see the actual tracks have the correct artists and splits listed. But the album artist title is being corrupted. For ex, ine album is credited to miles davis and michel legrand. It has made miles davis solo page that full name though. The amanda palmer one is especially egregious, but again you can see the actual track artist names are fine.

Any ideas on what could fix this? I've also included a few track files to reference.

[simonbun]

This is likely because you're linking one albumartist to two musicbrainz_albumartistid, as discussed previously: #707 (comment)

If you can't change the tags, creating an artist.nfo containing name and sortname should fix/mask the problem.

[Bigmack3000]

Archive.zip

oops the files didnt load with it last time.

I may be confused but wasn't most of this fixed with delimiters and the whitelist? because that wasn't my problem with names anymore. my issue had been that lms was just using the most recently added version of an artist name. after the update, it is now ignoring the delimiters but only for albumartist. track artists are still fine. So it's kind of reversed the issue. if it still used delimiters for albumartist, i think that would fix it because it would cut off "& the plastic ono band" from the name, right? or everything after amanda palmer.

I do plan on trying to batch create nfo files for artists soon. So if that will fix it, I will try it. is there a good sample nfo to work off of?

Thanks.

[simonbun]

I may be confused but wasn't most of this fixed with delimiters and the whitelist?

It's all flooding back to me now! When I first saw the "&" in the screenshots I knew that couldn't work as a delimiter as it would split up too many groups, but I had forgotten about the whitelist.

If @epoupon doesn't beat me to it I'll take a look at your examples tomorrow. What delimters and exclusions have you applied?

I do plan on trying to batch create nfo files for artists soon. So if that will fix it, I will try it. is there a good sample nfo to work off of?

All that's required is:

<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<artist>
    <musicBrainzArtistID>5441c29d-3602-4898-b1a1-b77fa23b8e50</musicBrainzArtistID>
    <name>David Bowie</name>
    <sortname>Bowie, David</sortname>
</artist>

[Bigmack3000]

If @epoupon doesn't beat me to it I'll take a look at your examples tomorrow. What delimters and exclusions have you applied?

Ha, uh I'm almost hesitant to say because it is a lot. I will say, outside of the these album artist ones, it works beautifully. But the white list is for the band names i want excluded from delimiters. so "John Lennon & the Plastic Ono Band" would not be on the whitelist because i would want it split into "John Lennon" and "Plastic Ono Band". and you'll see in the screenshot it did mostly do that. "Plastic Ono Band" is it's own artist. However, it took the first artist (John Lennon) and gave it the full album artist name: John Lennon & Plastic Ono Band". then it went to the second artist (Plastic Ono Band) and only put "Plastic Ono Band". But there are also plenty of albums that are tagged as only "John Lennon", so I'm not sure why it chose that particular album to represent his main overall page name.

thats a screenshot of all my current delimiters. I promise it works great. I don't think that is the problem.

[simonbun]

Both of those tracks are fine in 3.74 using the following delimiters:
" / "
"; "
", "
" & "

One thing I did notice is that musicbrainz ids aren't being split by the tag delimiters, so in this "collection" none were assigned mbids.

Could you send me a John Lennon/Plastic Ono Band example?

In the screenshot of "Moonlight Recital..." the albumartist "Haruomi Hosono & Tadanori Yokoo" is displayed, yet "Tadanori Yokoo" isn't one of the albumartists, at least not in the file you sent.

[Bigmack3000]

1-02 Hold On (Ultimate Mix).aiff.zip

03 Malabar Hotel Roof Garden... Revel Attack.mp3.zip

In the screenshot of "Moonlight Recital..." the albumartist "Haruomi Hosono & Tadanori Yokoo" is displayed, yet "Tadanori Yokoo" isn't one of the albumartists, at least not in the file you sent.

Yea, the haruomi one it took from a duet album of those two (Ive included one track in this post), and then made haruomis main name that full duet.

[Bigmack3000]

One thing I did notice is that musicbrainz ids aren't being split by the tag delimiters, so in this "collection" none were assigned mbids.

I also just wanted to clarify that the album artists (at least in prior versions) were separated according to the mbz release artist id. track artists use the mbz artist id.

[simonbun]

Yes they were being split correctly.

The mbid tags will only be used on tracks with a single AlbumArtist/Artist because mbid count (always 1 because mbid tag isn't multi-value and isn't being split by tag delimiter) <> artist count.
There is a setting in Scan Settings which may help, but can't remember what it's called at the moment. Will update when I'm home.

Did you rescan your library after updating to 3.74?

EDIT: Ignore everything I said about mbids as there's another delimiter setting for "splitting other tags". I think it's the first time I've really had to look at this screen!

[simonbun]

The John Lennon track used "/" as the delimiter between mbids so I had to configure that, but otherwise they worked fine.

Final config was:
Delimiters to be used for splitting artist tags: " / " "; " ", " " & "

Artists to not split using the delimiters (to get sort_name working):
Palmer, Amanda
Keating, Zoë
Lennon, Sean & Mitchell
John Cameron
Hosono, Haruomi
Yokoo, Tadanori
Yano, Akiko

Delimiters to be used for splitting other tags: "; " "/"

Resulting in:

sqlite> select id, name, sort_name, mbid from artist;
id  name                   sort_name                mbid
--  ---------------------  -----------------------  ------------------------------------
1   Amanda Palmer          Palmer, Amanda           3c0eb318-d2ba-45aa-9077-b83746cc56da
2   Zoë Keating            Keating, Zoë             0171668b-ba7a-4cef-8a28-22aa782dd56c
3   Sean Ono Lennon        Lennon, Sean & Mitchell  722c6718-0c61-4db2-a8bc-993a8c5d2baf
4   John Cameron Mitchell  John Cameron             dc8630ce-c5c3-49c4-a7b4-c7cb155f9b68
5   Joni Mitchell          Joni Mitchell
6   John Lennon            Lennon                   4d5447d7-c61c-4120-ba1b-d7f471d385b9
7   Plastic Ono Band       John                     84f81b32-8b3a-4914-9cff-017a52f9d16b
8   Haruomi Hosono         Hosono, Haruomi          078be324-de92-4c72-9371-65bdcf324154
9   Tadanori Yokoo         Yokoo, Tadanori          135ffbc2-77b1-4ac8-8691-a03d6f9d2915
10  Moonriders             Moon Riders              4f545074-e3c0-46f4-a2b7-e1489b979003
11  Akiko Yano             Yano, Akiko              b215b03a-8e0b-48ca-b832-bbbd0db504f0


sqlite> select id, type, artist_name, artist_sort_name, track_id, artist_id from track_artist_link;
id  type  artist_name            artist_sort_name         track_id  artist_id
--  ----  ---------------------  -----------------------  --------  ---------
1   0     Amanda Palmer          Palmer, Amanda           1         1
2   0     Zoë Keating            Keating, Zoë             1         2
3   0     Sean Ono Lennon        Lennon, Sean & Mitchell  1         3
4   0     John Cameron Mitchell  John Cameron             1         4
5   2     Joni Mitchell                                   1         5
6   4     Joni Mitchell                                   1         5
7   0     John Lennon            Lennon                   2         6
8   0     Plastic Ono Band       John                     2         7
9   2     John Lennon                                     2         6
10  4     John Lennon                                     2         6
11  0     Haruomi Hosono         Hosono, Haruomi          3         8
12  0     Tadanori Yokoo         Yokoo, Tadanori          3         9
13  0     Moonriders             Moon Riders              4         10
14  0     Haruomi Hosono         Hosono, Haruomi          4         8
15  0     Akiko Yano             Yano, Akiko              4         11

NOTE: There was only a single sort value mapped to the artists "John Lennon; Plastic Ono Band" so the sort names are incorrect.

At this point I hope it's just that for forgot to perform a rescan, because I'm not sure I can take any more 😉

[Bigmack3000]

Hmm, i did click for a full rescan initially. However, i did notice it took 3 hours when normally a full scan would take about 8, so maybe something disrupted it? Ill run another full scan and see if it's corrected.

[simonbun]

I assume the scanner page should contain the last successful scan date.

Failing that, specifically addressing the concatenated name on the Artist page, all I can think of is to track the name back to the album to hopefully identify a rogue tagging error.

The name in the artist table (used as header on the Artist page) must, I believe, originate from the track_artist_link table (all the artists linked to each track) so the following sql should return the albums containing the potential error.

NOTE: I'm assuming that release_artist_link is just a subset of track_artist_link (just the albumartists).

select distinct a.name as artist_name,
       a.mbid as artist_mbid,
       d.name as album_name,
       d.mbid as album_mbid
  from artist            a
         inner join
       track_artist_link b on (    a.id = b.artist_id
                               and a.name = b.artist_name)
         inner join
       track             c on (b.track_id = c.id)
         inner join
       release           d on (c.release_id = d.id)
  where a.name = 'John Lennon & Plastic Ono Band';

[Bigmack3000]

I'm running another full scan now, but looking through, and it appears that anytime an album artist has any type of multi artist album, it is choosing that one for it's main name. However, if you look at the individual albums on those pages, they all are credited correctly. but then if you look closer at the composer/lyrics/etc credits, they take on that random main name as well. But i don't know how they are even connected because theres no mbz ids for composers or lyrics. We'll see if another full scan corrects it, but it is just different from how it was treating these albums in prior versions. It never ignored a delimiter before.

fingers crossed, this scan puts it back in line. Also, if I create those nfo files and name them with each artists mbzid, that will overrule anything else?

[simonbun]

But i don't know how they are even connected because theres no mbz ids for composers or lyrics.

Do you have the option 'Allow merging artists without an MBID to those with one' enabled in Scan Settings? I don't know for sure if Composers and Lyricists are included in the merge, but I'd have thought they would be.
I know Picard by default doesn't provide composer and lyricist mbids but LMS does support them: https://github.com/epoupon/lms/blob/master/src/libs/audio/impl/taglib/TagReader.cpp

Do you use foobar2000 at all? It has a conversion feature that let's you truncate tracks so it's possible to compress entire artist discographies in a few MB for use in troubleshooting. I think the David Bowie album with Composer and Lyricist would be an interesting one to look at.

Creating .nfo files should solve the problem but it would be nice to understand exactly what's going on.

[Bigmack3000]

No, i dont have that selected. Down the line, I do plan to get the composers/lyricists/performers ids sorted out, but i haven't done that yet because i wanted to finish genres and artist images first. Plus, i wanted to wait until i know those credits would be separated into their own section on an artists page.

But no, currently none of that is set up so i wouldn't think it should be corrected by it.

Hard to tell just yet, but looking at the progress the scan has made so far, it feels like its going to be closer to 3 hours again instead of 8. So if that's two full scans at less than half the time, I'm thinking something is not being scanned in this version that was in the last. And my gut is saying delimiters and whitelist for actual Album Artists since that was also an area that was changed/updated in the latest version.

[simonbun]

I think there are too many moving parts to debug this remotely.

I think the next step should be to create a new test LMS instance using just the David Bowie/John Lennon folder/albums, and if that shows similar anomalies then to share the database.