After adding type annotations to the fmudesign module, i noticed that some types was too narrow and resulted in type check violations for another repo i was working on.
The relevant places is:
-
fmudesign.design_distributions.draw_values() (and draw_values_DISTTYPE): Type of dist_parameters should be Sequence[str | float], as it accepts both string and floats and eventually converts it to float
-
fmudesign.create_design.is_consistent_correlation_matrix(): Type of matrix works with pandas.DataFrame, and should be widened to also accept it.
I can create a PR that fixes this Soon™️
After adding type annotations to the
fmudesignmodule, i noticed that some types was too narrow and resulted in type check violations for another repo i was working on.The relevant places is:
fmudesign.design_distributions.draw_values()(anddraw_values_DISTTYPE): Type ofdist_parametersshould beSequence[str | float], as it accepts both string and floats and eventually converts it to floatfmudesign.create_design.is_consistent_correlation_matrix(): Type ofmatrixworks withpandas.DataFrame, and should be widened to also accept it.I can create a PR that fixes this Soon™️