Skip to content

Commit f8e0176

Browse files
various fixes (eclipse-score#420)
1 parent 299879b commit f8e0176

File tree

7 files changed

+17
-13
lines changed

7 files changed

+17
-13
lines changed

.devcontainer/devcontainer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{
22
"name": "eclipse-s-core",
3-
"image": "ghcr.io/eclipse-score/devcontainer:1.0.0",
3+
"image": "ghcr.io/eclipse-score/devcontainer:v1.2.0",
44
"updateContentCommand": "bazel run //:ide_support"
55
}

.github/actions/link-check/link_parser.py

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -51,9 +51,7 @@ def generate_markdown_table(broken_links: list[BrokenLink]) -> str:
5151
table += "|----------|-------------|-----------|\n"
5252

5353
for link in broken_links:
54-
table += (
55-
f"| {link.location} | {link.line_nr} | {link.reasoning} |\n"
56-
)
54+
table += f"| {link.location} | {link.line_nr} | {link.reasoning} |\n"
5755

5856
return table
5957

@@ -62,7 +60,7 @@ def generate_issue_body(broken_links: list[BrokenLink]) -> str:
6260
markdown_table = generate_markdown_table(broken_links)
6361
return f"""
6462
# Broken Links Report.
65-
**Last updated: {datetime.now().strftime('%d-%m-%Y %H:%M')}**
63+
**Last updated: {datetime.now().strftime("%d-%m-%Y %H:%M")}**
6664
6765
The following broken links were detected in the documentation:
6866
{markdown_table}
@@ -73,7 +71,8 @@ def generate_issue_body(broken_links: list[BrokenLink]) -> str:
7371
7472
---
7573
This issue will be auto updated regularly if link issues are found.
76-
You may close it if you wish, though a new one will be created if link issues are still present.
74+
You may close it if you wish.
75+
Though a new one will be created if link issues are still present.
7776
7877
"""
7978

@@ -85,11 +84,11 @@ def strip_ansi_codes(text: str) -> str:
8584

8685

8786
if __name__ == "__main__":
88-
argparse = argparse.ArgumentParser(
87+
arg = argparse.ArgumentParser(
8988
description="Parse broken links from Sphinx log and generate issue body."
9089
)
91-
argparse.add_argument("logfile", type=str, help="Path to the Sphinx log file.")
92-
args = argparse.parse_args()
90+
arg.add_argument("logfile", type=str, help="Path to the Sphinx log file.")
91+
args = arg.parse_args()
9392
with open(args.logfile) as f:
9493
log_content_raw = f.read()
9594
log_content = strip_ansi_codes(log_content_raw)

src/BUILD

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313

1414
load("@aspect_rules_lint//format:defs.bzl", "format_multirun", "format_test")
1515
load("@aspect_rules_py//py:defs.bzl", "py_library")
16+
load("@rules_java//java:java_binary.bzl", "java_binary")
1617
load("@rules_python//python:pip.bzl", "compile_pip_requirements")
1718
load("@score_tooling//:defs.bzl", "dash_license_checker")
1819

src/extensions/BUILD

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,7 @@
1111
# SPDX-License-Identifier: Apache-2.0
1212
# *******************************************************************************
1313

14-
load("@aspect_rules_py//py:defs.bzl", "py_binary", "py_library")
15-
load("@docs_as_code_hub_env//:requirements.bzl", "all_requirements")
16-
load("@score_tooling//:defs.bzl", "score_py_pytest", "score_virtualenv")
14+
load("@aspect_rules_py//py:defs.bzl", "py_library")
1715

1816
py_library(
1917
name = "score_plantuml",

src/helper_lib/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
import sys
1717
from pathlib import Path
1818

19-
from python.runfiles import Runfiles
19+
from runfiles import Runfiles
2020
from sphinx_needs.logging import get_logger
2121

2222
LOGGER = get_logger(__name__)

src/requirements.in

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,3 +30,6 @@ rich
3030
needs-config-writer == 0.2.4
3131
# use this for a specific commit for fast development iterations
3232
# needs-config-writer @ https://github.com/useblocks/needs-config-writer/archive/032a5f8.zip
33+
34+
# Need this to enable non bazel exectuion
35+
bazel-runfiles

src/requirements.txt

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,9 @@ basedpyright==1.35.0 \
3434
--hash=sha256:2a7e0bd476623d48499e2b18ff6ed19dc28c51909cf9e1152ad355b5809049ad \
3535
--hash=sha256:4f4f84023df5a0cd4ee154916ba698596682ac98bacfa22c941ed6aaf07bba4e
3636
# via -r /external/score_tooling+/python_basics/requirements.txt
37+
bazel-runfiles==1.8.5 \
38+
--hash=sha256:7c34df05e0115e5559cbc3069b580ef66e330e7f5dde29dba50f312dfad346d9
39+
# via -r src/requirements.in
3740
beautifulsoup4==4.14.3 \
3841
--hash=sha256:0918bfe44902e6ad8d57732ba310582e98da931428d231a5ecb9e7c703a735bb \
3942
--hash=sha256:6292b1c5186d356bba669ef9f7f051757099565ad9ada5dd630bd9de5fa7fb86

0 commit comments

Comments
 (0)