Skip to content

Use go-ipa for Multiproof point deserialization #392

Description

@jsign

Currently, we have some custom code to deserialize a Multiproof. In go-ipa, there's a specific API to do this deserialization.

Both styles are a bit different since go-ipa expects an opaque stream of bytes and does the deserialization. Here, in go-verkle, we have the serialized proof already in parts, which probably explains why we have some custom code.

In any case, we must rely on go-ipa to do any deserialization to know this is done safely. If that means changing go-ipa APIs since we need to pass these "parts", I think that's fine. But let's try to rely on go-ipa for any security issues since it has (and will continue to have) more tests (and audits) to be sure these APIs are safe.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions