Add ko-KR, ko-KR-x-busan, and ja-JP-x-oita locales to i18n#151
Draft
Add ko-KR, ko-KR-x-busan, and ja-JP-x-oita locales to i18n#151
Conversation
Co-authored-by: nyanrus <68762426+nyanrus@users.noreply.github.com>
Co-authored-by: nyanrus <68762426+nyanrus@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add language translations for Korean and Japanese regions
Add ko-KR, ko-KR-x-busan, and ja-JP-x-oita locales to i18n
Oct 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds three new locales to the internationalization (i18n) system:
Added Locales
1. ko-KR (Korean)
Base Korean locale with translations and fallback to en-US. Includes Korean translation for the "undo-closed-tab" feature:
2. ko-KR-x-busan (Korean - Busan dialect)
Regional variant for the Busan dialect with fallback to ko-KR. Currently uses an empty translation object to leverage the fallback chain, ready for future dialect-specific translations.
3. ja-JP-x-oita (Japanese - Oita dialect)
Regional variant for the Oita dialect with fallback to ja-JP. Currently uses an empty translation object to leverage the fallback chain, ready for future dialect-specific translations.
Structure
Each locale directory follows the established pattern:
Fallback Chain
The locales implement proper fallback chains:
This ensures users always see appropriate translations even when dialect-specific translations are not available.
Implementation Notes
config.tsusesimport.meta.globwhich automatically discovers and loads these new locale directoriesOriginal prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.