.

Author: asukaminato0721

pyrefly/lib/binding/expr.rs

@@ -801,10 +801,10 @@ impl<'a> BindingsBuilder<'a> {
     }
 
     fn check_private_attribute_usage(&mut self, attr: &ExprAttribute) {
-        if self.scopes.in_function_scope() {
+        if !Ast::is_mangled_attr(&attr.attr.id) {
             return;
         }
-        if Ast::is_mangled_attr(&attr.attr.id) {
+        if !self.scopes.in_function_scope() {
             self.error(
                 attr.attr.range,
                 ErrorInfo::Kind(ErrorKind::NoAccess),
@@ -813,6 +813,17 @@ impl<'a> BindingsBuilder<'a> {
                     attr.attr.id
                 ),
             );
+            return;
+        }
+        if self.scopes.current_method_and_class().is_none() {
+            self.error(
+                attr.attr.range,
+                ErrorInfo::Kind(ErrorKind::NoAccess),
+                format!(
+                    "Private attribute `{}` can only be accessed from methods",
+                    attr.attr.id
+                ),
+            );
         }
     }
 

pyrefly/lib/test/attributes.rs

@@ -1259,8 +1259,13 @@ exposed = A.__secret  # E: Private attribute `__secret` cannot be accessed outsi
 class B:
     leaked = A.__secret  # E: Private attribute `__secret` cannot be accessed outside a function
 
-def ok(a: A) -> int:
-    return A.__secret  # OK
+def fn_bad(a: A) -> int:
+    return a.__secret  # E: Private attribute `__secret` can only be accessed from methods
+
+class C:
+    __secret: int = 0
+    def good(self) -> int:
+        return self.__secret  # OK
 "#,
 );