Fix unused exception parameter compile error in RCTUIManager catch block#55064
Open
yannickl wants to merge 1 commit intofacebook:mainfrom
Open
Fix unused exception parameter compile error in RCTUIManager catch block#55064yannickl wants to merge 1 commit intofacebook:mainfrom
yannickl wants to merge 1 commit intofacebook:mainfrom
Conversation
Summary:
In some configurations the errors might be stripped out and leading toward those kind of issues:
```
stderr:
xplat/js/react-native-github/packages/react-native/React/Modules/RCTUIManager.mm:1251:28: error: unused exception parameter 'exception' [-Werror,-Wunused-exception-parameter]
1251 | } catch (NSException \*exception) {
| ^\~\~\~\~\~\~\~\~
1 error generated.
```
So marking the param as potentially unused.
Reviewed By: lodhaayush
Differential Revision: D90192993
meta-cla
bot
added
the
CLA Signed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
In some configurations the errors might be stripped out and leading toward those kind of issues:
So marking the param as potentially unused.
Reviewed By: lodhaayush
Differential Revision: D90192993