Fling: Cleanup enableVirtualViewExperimental Feature Flag
#55065
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Ships the feature flag to use `useInsertionEffect` in `Pressability`, instead of `useEffect`. Using `useInsertionEffect` enables `Pressability` to behave more predictability in component trees with `<Activity mode="hidden">` because the events are scheduled more similarly to platform controls (e.g. focus and blur events will still fire even when "hidden"). Changelog: [General][Changed] - `Pressable` no longer unmounts event listeners in a hidden `Activity`. Reviewed By: lunaleaps, javache Differential Revision: D90192717
Summary: Cleans up the `enableVirtualViewExperimental` feature flag, so that only the experimental one is ever used. This does not delete the original implementation or rename the experimental one. I'll do those separately as follow-ups. Changelog: [Internal] Reviewed By: lunaleaps Differential Revision: D90193651
|
@yungsters has exported this pull request. If you are a Meta employee, you can view the originating Diff in D90193651. |
meta-cla
bot
added
the
CLA Signed
Collaborator
|
This pull request was successfully merged by @yungsters in 758a3db When will my fix make it into a release? | How to file a pick request? |
|
This pull request has been merged in 758a3db. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Cleans up the
enableVirtualViewExperimentalfeature flag, so that only the experimental one is ever used.This does not delete the original implementation or rename the experimental one. I'll do those separately as follow-ups.
Changelog:
[Internal]
Reviewed By: lunaleaps
Differential Revision: D90193651