Use public URL for webhook e2e tests (#145)

* Use public URL for webhook e2e tests

* Align destination list e2e DST assertion

Author: fivetran-jovanmanojlovic

test_utils/test_utils.go

@@ -713,7 +713,7 @@ func DeleteWebhook(t *testing.T, id string) {
 func CreateWebhookAccount(t *testing.T) string {
     t.Helper()
     created, err := Client.NewWebhookAccountCreate().
-        Url("https://localhost:12345").
+        Url("https://example.com").
         Secret("my_secret").
         Active(false).
         Events([]string{"sync_start", "sync_end"}).

tests/e2e/destinations_list_test.go

@@ -24,7 +24,7 @@ func TestNewDestinationsListE2E(t *testing.T) {
 	testutils.AssertEqual(t, result.Data.Items[0].Service, "snowflake")
 	testutils.AssertEqual(t, result.Data.Items[0].Region, "GCP_US_EAST4")
 	testutils.AssertEqual(t, result.Data.Items[0].TimeZoneOffset, "+10")
-	testutils.AssertEqual(t, result.Data.Items[0].DaylightSavingTimeEnabled, false)
+	testutils.AssertEqual(t, result.Data.Items[0].DaylightSavingTimeEnabled, true)
 	testutils.AssertEmpty(t, result.Data.Items[0].PrivateLinkId)
 	testutils.AssertEmpty(t, result.Data.Items[0].ProxyAgentId)
 	testutils.AssertEmpty(t, result.Data.Items[0].HybridDeploymentAgentId)

tests/e2e/webhook_account_create_test.go

@@ -9,7 +9,7 @@ import (
 
 func TestNewWebhookAccountCreateE2E(t *testing.T) {
 	created, err := testutils.Client.NewWebhookAccountCreate().
-		Url("https://localhost:12345").
+		Url("https://example.com").
 		Secret("my_secret").
 		Active(false).
 		Events([]string{"sync_start", "sync_end"}).
@@ -29,7 +29,7 @@ func TestNewWebhookAccountCreateE2E(t *testing.T) {
 	testutils.AssertEqual(t, created.Data.Type, "account")
 	testutils.AssertEqual(t, created.Data.Active, false)
 	testutils.AssertEqual(t, created.Data.Secret, "******")
-	testutils.AssertEqual(t, created.Data.Url, "https://localhost:12345")
+	testutils.AssertEqual(t, created.Data.Url, "https://example.com")
 	testutils.AssertEqual(t, created.Data.Events, []string{"sync_start", "sync_end"})
 
 	t.Cleanup(func() { testutils.DeleteWebhook(t, created.Data.Id) })

tests/e2e/webhook_details_test.go

@@ -23,7 +23,7 @@ func TestWebhookDetailsE2E(t *testing.T) {
 	testutils.AssertEmpty(t, result.Data.GroupId)
 	testutils.AssertEqual(t, result.Data.Type, "account")
 	testutils.AssertEqual(t, result.Data.Secret, "******")
-	testutils.AssertEqual(t, result.Data.Url, "https://localhost:12345")
+	testutils.AssertEqual(t, result.Data.Url, "https://example.com")
 	testutils.AssertEqual(t, result.Data.Events, []string{"sync_start", "sync_end"})
 	testutils.AssertEqual(t, result.Data.Active, false)
 

tests/e2e/webhook_group_create_test.go

@@ -9,7 +9,7 @@ import (
 
 func TestNewWebhookGroupCreateE2E(t *testing.T) {
 	created, err := testutils.Client.NewWebhookGroupCreate().
-		Url("https://localhost:12345").
+		Url("https://example.com").
 		Secret("my_secret").
 		GroupId(testutils.PredefinedGroupId).
 		Active(false).
@@ -31,7 +31,7 @@ func TestNewWebhookGroupCreateE2E(t *testing.T) {
 	testutils.AssertEqual(t, created.Data.Active, false)
 	testutils.AssertEqual(t, created.Data.GroupId, testutils.PredefinedGroupId)
 	testutils.AssertEqual(t, created.Data.Secret, "******")
-	testutils.AssertEqual(t, created.Data.Url, "https://localhost:12345")
+	testutils.AssertEqual(t, created.Data.Url, "https://example.com")
 	testutils.AssertEqual(t, created.Data.Events, []string{"sync_start", "sync_end"})
 
 	t.Cleanup(func() { testutils.DeleteWebhook(t, created.Data.Id) })

tests/e2e/webhook_update_test.go

@@ -12,7 +12,7 @@ func TestWebhookUpdateE2E(t *testing.T) {
 
 	updated, err := testutils.Client.NewWebhookUpdate().
 		WebhookId(webhookId).
-		Url("https://localhost:12345").
+		Url("https://example.com").
 		Secret("my_secret").
 		Active(false).
 		Events([]string{"sync_start", "sync_end"}).
@@ -31,7 +31,7 @@ func TestWebhookUpdateE2E(t *testing.T) {
 	testutils.AssertNotEmpty(t, updated.Data.Type)
 	testutils.AssertEqual(t, updated.Data.Active, false)
 	testutils.AssertEqual(t, updated.Data.Secret, "******")
-	testutils.AssertEqual(t, updated.Data.Url, "https://localhost:12345")
+	testutils.AssertEqual(t, updated.Data.Url, "https://example.com")
 	testutils.AssertEqual(t, updated.Data.Events, []string{"sync_start", "sync_end"})
 
 	t.Cleanup(func() { testutils.DeleteWebhook(t, webhookId) })