deathlock

[huangchuyan]

deathlock with this lock
UPNP::GetInstance()->GetSSDP()->GetDB()->Lock();

tow functions have this issue
int SSDPSearchResp::Process(struct sockaddr* sender, std::vector<SSDP_HTTP_HEADER*> msgheaders)
int SSDPNotifyAlive::Process(struct sockaddr* sender, std::vector<SSDP_HTTP_HEADER*> msgheaders)

its call:
mDB->Lock();
and call:
mDB->DeviceUpdate(device);

mDB->DeviceUpdate(device); also call:UPNP::GetInstance()->GetSSDP()->GetDB()->Lock();

the deathlock appear

can you also find this issue?

[huangchuyan]

I modify it

**//Inform the observers
if(uuid.isdevice || uuid.isrootdevice){
mDB->DeviceUpdate(device);
}else if(uuid.isservice){
mDB->ServiceUpdate(device);
}

}

//always update cache control
if(device != NULL && cache >= 0){
mDB->UpdateCacheControl(uuid.uuid, uuid.uuidlen, cache);
}
mDB->Unlock();**

to
**//end workaround

    mDB->Unlock();
    //Inform the observers
    if(uuid.isdevice || uuid.isrootdevice){
        mDB->DeviceUpdate(device);
    }else if(uuid.isservice){
        mDB->ServiceUpdate(device);
    }

}
else
{
    mDB->Unlock();
}**

[xaphod]

I do not see where SSDPDB::DeviceUpdate calls UPNP::GetInstance()->GetSSDP()->GetDB()->Lock()
Are you on 1.4.0a2 or an older version?
Which line of which file do you see SSDPDB::DeviceUpdate calling lock() ?

[huangchuyan]

callstack：

ssdpsearchresp.cpp
line:135 mDB->DeviceUpdate(device);

ssdpdb.cpp
line:235 ((SSDPDBObserver_)_it)->SSDPDBMessage(&msg);

SSDPDB_Objc.mm
line:59 [mObjCObserver SSDPDBUpdate];

SSDPDB_Objc.mm
line:215 UPNP::GetInstance()->GetSSDP()->GetDB()->Lock();