Filter support

[Anachron]

Do you mind adding support for before and after filters? I think it's not good to overwrite an overwritten method by myself, even if I could.

This basically is what I want to use with subRoute support: https://github.com/boazsender/backbone.routefilter

[geekdave]

@Anachron : I'd welcome a pull request for this feature... but it's unlikely that I'll have the time to implement it myself. Please let me know if you're interested in working on this.

[Anachron]

@geekdave well did you take a look at that library? It's just 100 lines long and pretty self explaining 👍

[geekdave]

@Anachron: Regardless of how many lines of code your feature would take to implement, there is time involved in writing tests, documenting, regression testing, etc.

It's generally poor form in the Open Source community to suggest that someone else should have the time to work on something that you, yourself are unwilling to spend time on doing yourself.

As I said, I would be happy to entertain this feature as a PR. If you're just not sure how to do it, you can find this project's PR requirements here: https://github.com/ModelN/backbone.subroute#pull-requests , and there are lots of guides out there on the interwebz for how to contribute a PR back to a project.

I'd be glad to help if you are unsure about anything in the PR process. But simply insisting that it's a small enough change that I should do it is not likely to get you very far. 😉

[Anachron]

@geekdave well thanks for the kind words. Actually I'm pretty busy myself, maybe I will find some time to make a PR. Tests are a must, I can see?

[Pleochism]

@Anachron, I've merged these two projects already for my own use. It was a quick and dirty job, so the routefilter tests haven't been ported over, but maybe it'll save you a bit of time if you're still interested in this. I intend to complete the tests myself and submit a PR, but I won't have time for a couple months at least.

https://github.com/Pleochism/backbone.subroute