implement btc/bch/zcash signing in rust#1143
Open
0xh3rman wants to merge 9 commits into
Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request implements signing support for Bitcoin, Bitcoin Cash, Litecoin, Dogecoin, and Zcash, introducing a new BitcoinChainSigner and a transaction planner with fee estimation. The review feedback identifies critical performance improvements, such as precomputing sighash components to prevent O(N^2) complexity and optimizing the use of cryptographic contexts. Additionally, the reviewer recommends implementing dust threshold checks for transaction amounts and utilizing standard library abstractions for address parsing to enhance code reliability and maintainability.
0xh3rman
force-pushed
the
bitcoin-signer
branch
3 times, most recently
from
218265e to
ddf7c26
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.