Remove dead code and minor cleanups (#537)

iOS: delete unused StateView; use displayScale in AsyncImageView; build TransactionStateViewModel once in titleTagTextValue. Android: hoist LocalUriHandler/LocalContext out of links list items; drop duplicate flow.map import; remove dead commented code in AssetItem and ImportScreen.

Author: DRadmir

android/features/asset/presents/src/main/kotlin/com/gemwallet/android/features/asset/presents/chart/AssetChartScene.kt

@@ -1,5 +1,6 @@
 package com.gemwallet.android.features.asset.presents.chart
 
+import android.content.Context
 import androidx.compose.foundation.clickable
 import com.gemwallet.android.ext.AddressFormatter
 import androidx.compose.foundation.layout.Column
@@ -16,6 +17,7 @@ import androidx.compose.ui.Alignment
 import androidx.compose.ui.Modifier
 import androidx.compose.ui.platform.LocalContext
 import androidx.compose.ui.platform.LocalUriHandler
+import androidx.compose.ui.platform.UriHandler
 import androidx.compose.ui.platform.testTag
 import androidx.compose.ui.res.stringResource
 import androidx.hilt.lifecycle.viewmodel.compose.hiltViewModel
@@ -77,6 +79,8 @@ fun AssetChartScene(
     val isChartRefreshing by chartViewModel.isRefreshing.collectAsStateWithLifecycle()
     val pullToRefreshState = rememberPullToRefreshState()
     val snackbar = rememberSnackbarState(message = toastMessage, onShown = onToastShown)
+    val uriHandler = LocalUriHandler.current
+    val context = LocalContext.current
 
     Scene(
         title = title,
@@ -112,7 +116,7 @@ fun AssetChartScene(
                     assetContract(it.asset, it.explorerName)
                     assetSupply(it.asset, it.marketInfo)
                     assetAllTime(it.currency, it.asset, it.marketInfo)
-                    links(it.assetLinks)
+                    links(it.assetLinks, uriHandler, context)
                 }
             }
         }
@@ -157,12 +161,10 @@ private fun PriceAlertsItem(
     )
 }
 
-private fun LazyListScope.links(links: List<AssetMarketUIModel.Link>) {
+private fun LazyListScope.links(links: List<AssetMarketUIModel.Link>, uriHandler: UriHandler, context: Context) {
     if (links.isEmpty()) return
     item { SubheaderItem(R.string.social_links) }
     itemsIndexed(links) { index, item ->
-        val uriHandler = LocalUriHandler.current
-        val context = LocalContext.current
         PropertyItem(
             modifier = Modifier.clickable { uriHandler.open(context, item.url) },
             title = { PropertyTitleText(item.label, trailing = { AsyncImage(model = item.icon, size = smallIconSize) }) },

android/features/confirm/viewmodels/src/main/kotlin/com/gemwallet/android/features/confirm/viewmodels/ConfirmViewModel.kt

@@ -48,7 +48,6 @@ import kotlinx.coroutines.flow.flatMapLatest
 import kotlinx.coroutines.flow.map
 import kotlinx.coroutines.flow.flowOf
 import kotlinx.coroutines.flow.flowOn
-import kotlinx.coroutines.flow.map
 import kotlinx.coroutines.flow.mapNotNull
 import kotlinx.coroutines.flow.stateIn
 import kotlinx.coroutines.flow.update

android/features/import_wallet/presents/src/main/kotlin/com/gemwallet/android/features/import_wallet/views/ImportScreen.kt

@@ -298,7 +298,7 @@ private fun TypeSelection(
         modifier = Modifier.fillMaxWidth().clip(RoundedCornerShape(4.dp)),
         selectedTabIndex = importTypeTabIndex(importType.walletType, importType.chain),
         indicator = { Box {} },
-        containerColor = Color.Transparent,//(0xFFEBEBEB),
+        containerColor = Color.Transparent,
         divider = {}
     ) {
         importWalletTabs(importType.chain).forEach { walletType ->

android/ui/src/main/kotlin/com/gemwallet/android/ui/components/list_item/AssetItem.kt

@@ -190,7 +190,7 @@ fun PriceInfo(
                 Modifier.background(color.copy(alpha = alpha10), MaterialTheme.shapes.small)
             } else {
                 Modifier
-            },//.padding(horizontal = 4.dp),
+            },
             text = changes,
             color = color,
             style = style,

ios/Packages/Components/Sources/AsyncImageView.swift

@@ -4,6 +4,8 @@ import Style
 import SwiftUI
 
 public struct AsyncImageView: View {
+    @Environment(\.displayScale) private var displayScale
+
     let url: URL?
     let size: CGFloat
     let placeholder: Placeholder
@@ -23,7 +25,7 @@ public struct AsyncImageView: View {
     }
 
     public var body: some View {
-        CachedAsyncImage(url: url, scale: UIScreen.main.scale) {
+        CachedAsyncImage(url: url, scale: displayScale) {
             $0.resizable()
         } placeholder: {
             switch placeholder {

ios/Packages/Components/Sources/StateView/StateView.swift

@@ -154,11 +154,11 @@ public struct TransactionViewModel: Sendable {
     }
 
     public var titleTagTextValue: TextValue? {
+        let model = TransactionStateViewModel(state: transaction.transaction.state)
         let title: String? = switch transaction.transaction.state {
         case .confirmed: .none
-        case .pending, .inTransit, .failed, .reverted: TransactionStateViewModel(state: transaction.transaction.state).title
+        case .pending, .inTransit, .failed, .reverted: model.title
         }
-        let model = TransactionStateViewModel(state: transaction.transaction.state)
         return title.map {
             TextValue(
                 text: $0,
@@ -312,10 +312,6 @@ public struct TransactionViewModel: Sendable {
         }
     }
 
-    private var addressLink: BlockExplorerLink {
-        explorerService.addressUrl(chain: assetId.chain, address: participant)
-    }
-
     private var assetId: AssetId {
         transaction.transaction.assetId
     }