Task reaper: When purging old closed tasks from 0.6 in 0.7, tasks in the "Dismissed" status do not get purged?

[nekohayo]

I'm not entirely sure what's going on there because I actually have no visual indication of whether the Purge button actually works or not in 0.7 (see #1336), but I think the current git master version towards 0.7 has a problem where it can't purge some tasks using this action in the Preferences dialog:

In my case, using my real dataset (from 0.6), when clicking that button nothing happens even if I set the threshold to 1 day, and looking at the list of Closed tasks in the main window that list does not seem to shrink to a small amount of tasks.

Furthermore, when opening some of those closed tasks, I saw that some of them had nothing in the "Closed date" field.

@pentux-GitHub are you able to test and reproduce this issue somehow? Did I hallucinate this bug, or does it actually exist in 0.7? If I have to guess, I would suspect something related to the import or parsing of closed date for done vs dismissed tasks of 0.6 vs 0.7, but I'm not sure…

[pentux-GitHub]

Reproduced, and your hunch was close: the culprit is the 0.7 serializer, not the import. It only wrote the closed date of Done tasks, so every Dismissed task lost its date on the first save, and a dateless closed task is invisible to the reaper, today minus no_date being -9999 days. #1354 fixes the serializer and heals damaged files at load, verified on a real dataset: ten stripped dismissed tasks got honest dates back and were purged as expected.

Your done tasks not purging is a second, distinct defect: on my bench every done task had its closed date overwritten with the current day, so they all look too young to purge. Still investigating, it predates the serializer fix. The editor Dismiss button is also dead, it calls a method that does not exist, fix coming separately.

[pentux-GitHub]

Both defects behind this issue are now fixed on master. #1354, merged, repairs the serializer that silently dropped the closed date of Dismissed tasks, and heals already damaged files at load. #1358, merged today, stops the CalDAV sync from overwriting closed dates with the day of the sync, which is what made every Done task look too young to purge. The dead Dismiss button in the editor is fixed as well (#1356).

@nekohayo a retest of the purge on current master with your real dataset would be the final word on this issue. One expectation to set: Done tasks whose closed date was already destroyed by the sync bug keep their stamped date, the fix prevents new damage but cannot invent dates that are gone from the file. Dismissed tasks are healed at load. So after purging with a 1 day threshold, what remains should be the recently stamped ones, not the historically old ones.