Skip to content

Commit 017d988

Browse files
authored
Fix dark mode styling for code blocks in Book pages (#2122)
Book pages were missing proper dark-mode styling for inline and block code elements due to existing `.edition2 code` rules overriding the theme styles. This change adds scoped dark-mode styles for `.edition2 .book` `code` and `pre` elements using existing design tokens, aligning Book pages with Docs styling and restoring proper contrast in dark mode. Fixes #2120
2 parents dd89378 + 706212a commit 017d988

File tree

2 files changed

+17
-101
lines changed

2 files changed

+17
-101
lines changed

assets/sass/book2.scss

Lines changed: 10 additions & 101 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,8 @@
11
.edition2 {
2+
/* Book code colors (light mode defaults) */
3+
--book-code-color: #333;
4+
--book-code-bg: #eee;
5+
--book-code-border: #f5f5f5;
26
* {
37
box-sizing: border-box;
48
}
@@ -474,11 +478,11 @@
474478
}
475479

476480
pre {
477-
background: #eee;
481+
background: var(--book-code-bg);
478482

479483
code {
480484
display: inline;
481-
background: #eee;
485+
background: var(--book-code-bg);
482486
border: 0;
483487
}
484488
}
@@ -488,14 +492,14 @@
488492
overflow-x: auto;
489493
font-size: 0.9em;
490494
line-height: 120%;
491-
color: #333;
495+
color: var(--book-code-color);
492496
}
493497

494498
code { /* inline code */
495499
padding: 0;
496-
color: #333;
497-
background: #eee;
498-
border: 1px solid #f5f5f5;
500+
color: var(--book-code-color);
501+
background: var(--book-code-bg);
502+
border: 1px solid var(--book-code-border);
499503
}
500504

501505
table pre { /* code blocks within tables */
@@ -608,99 +612,4 @@
608612
text-indent: 0;
609613
}
610614
}
611-
612-
/* syntax highlighting and coloring text in general */
613-
614-
/* Pygments with manni theme */
615-
pre code.hll { background-color: #ffffcc }
616-
pre code.c { color: #0099FF; font-style: italic } /* Comment */
617-
pre code.err { color: #AA0000 } /* Error */
618-
pre code.k { color: #006699; font-weight: bold } /* Keyword */
619-
pre code.o { color: #555555 } /* Operator */
620-
pre code.cm { color: #35586C; font-style: italic } /* Comment.Multiline */
621-
pre code.cp { color: #009999 } /* Comment.Preproc */
622-
pre code.c1 { color: #35586C; font-style: italic } /* Comment.Single */
623-
pre code.cs { color: #35586C; font-weight: bold; font-style: italic } /* Comment.Special */
624-
pre code.gd { background-color: #FFCCCC } /* Generic.Deleted */
625-
pre code.ge { font-style: italic } /* Generic.Emph */
626-
pre code.gr { color: #FF0000 } /* Generic.Error */
627-
pre code.gh { color: #003300; font-weight: bold } /* Generic.Heading */
628-
pre code.gi { background-color: #CCFFCC } /* Generic.Inserted */
629-
630-
/* Overriding default manni style of #AAAAAA gray for Generic Output with #000000 black, which is better suited to ORM terminal output */
631-
pre code.go { color: #000000 } /* Generic.Output */
632-
633-
pre code.gp { color: #000099; font-weight: bold } /* Generic.Prompt */
634-
pre code.gs { font-weight: bold } /* Generic.Strong */
635-
pre code.gu { color: #003300; font-weight: bold } /* Generic.Subheading */
636-
pre code.gt { color: #99CC66 } /* Generic.Traceback */
637-
pre code.kc { color: #006699; font-weight: bold } /* Keyword.Constant */
638-
pre code.kd { color: #006699; font-weight: bold } /* Keyword.Declaration */
639-
pre code.kn { color: #006699; font-weight: bold } /* Keyword.Namespace */
640-
pre code.kp { color: #006699 } /* Keyword.Pseudo */
641-
pre code.kr { color: #006699; font-weight: bold } /* Keyword.Reserved */
642-
pre code.kt { color: #007788; font-weight: bold } /* Keyword.Type */
643-
pre code.m { color: #FF6600 } /* Literal.Number */
644-
pre code.s { color: #CC3300 } /* Literal.String */
645-
pre code.na { color: #330099 } /* Name.Attribute */
646-
pre code.nb { color: #336666 } /* Name.Builtin */
647-
pre code.nc { color: #00AA88; font-weight: bold } /* Name.Class */
648-
pre code.no { color: #336600 } /* Name.Constant */
649-
pre code.nd { color: #9999FF } /* Name.Decorator */
650-
pre code.ni { color: #999999; font-weight: bold } /* Name.Entity */
651-
pre code.ne { color: #CC0000; font-weight: bold } /* Name.Exception */
652-
pre code.nf { color: #CC00FF } /* Name.Function */
653-
pre code.nl { color: #9999FF } /* Name.Label */
654-
pre code.nn { color: #00CCFF; font-weight: bold } /* Name.Namespace */
655-
pre code.nt { color: #330099; font-weight: bold } /* Name.Tag */
656-
pre code.nv { color: #003333 } /* Name.Variable */
657-
pre code.ow { color: #000000; font-weight: bold } /* Operator.Word */
658-
pre code.w { color: #bbbbbb } /* Text.Whitespace */
659-
pre code.mf { color: #FF6600 } /* Literal.Number.Float */
660-
pre code.mh { color: #FF6600 } /* Literal.Number.Hex */
661-
pre code.mi { color: #FF6600 } /* Literal.Number.Integer */
662-
pre code.mo { color: #FF6600 } /* Literal.Number.Oct */
663-
pre code.sb { color: #CC3300 } /* Literal.String.Backtick */
664-
pre code.sc { color: #CC3300 } /* Literal.String.Char */
665-
pre code.sd { color: #CC3300; font-style: italic } /* Literal.String.Doc */
666-
pre code.s2 { color: #CC3300 } /* Literal.String.Double */
667-
pre code.se { color: #CC3300; font-weight: bold } /* Literal.String.Escape */
668-
pre code.sh { color: #CC3300 } /* Literal.String.Heredoc */
669-
pre code.si { color: #AA0000 } /* Literal.String.Interpol */
670-
pre code.sx { color: #CC3300 } /* Literal.String.Other */
671-
pre code.sr { color: #33AAAA } /* Literal.String.Regex */
672-
pre code.s1 { color: #CC3300 } /* Literal.String.Single */
673-
674-
/* Overriding manni default yellow #FFCC33 with brown #AA6600, which is easier to read */
675-
pre code.ss { color: #AA6600 } /* Literal.String.Symbol */
676-
677-
pre code.bp { color: #336666 } /* Name.Builtin.Pseudo */
678-
pre code.vc { color: #003333 } /* Name.Variable.Class */
679-
pre code.vg { color: #003333 } /* Name.Variable.Global */
680-
pre code.vi { color: #003333 } /* Name.Variable.Instance */
681-
pre code.il { color: #FF6600 } /* Literal.Number.Integer.Long */
682-
683-
/* Sanders's additions to manni */
684-
pre code.g { color: #005500 } /* Generic */
685-
pre code.l { color: #CC6600 } /* Literal */
686-
pre code.l { color: #FF9900 } /* Literal.Date */
687-
pre code.n { color: #000088 } /* Name */
688-
pre code.nx { color: #000088 } /* Name.Other */
689-
pre code.py { color: #9966FF } /* Name.Property */
690-
pre code.p { color: #000000 } /* Punctuation */
691-
pre code.x { color: #FF0066 } /* Other */
692-
693-
/* Chacon's additions to make command line look more like a command line */
694-
pre[data-code-language="console"] {
695-
padding: 10px;
696-
background: #eee;
697-
}
698-
pre[data-code-language="console"] code.go {
699-
font-size: 1.0em;
700-
color: #555;
701-
}
702-
pre[data-code-language="console"] code.gp {
703-
font-weight: bold;
704-
color: #009900;
705-
}
706615
}

assets/sass/dark-mode.scss

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -83,6 +83,13 @@
8383
z-index: -1;
8484
}
8585

86+
/* Book pages: code colors */
87+
.edition2 {
88+
--book-code-color: #{$fixed-width-font-color};
89+
--book-code-bg: #{$no-changes-bg-color};
90+
--book-code-border: #{$pre-border};
91+
}
92+
8693
img {
8794
filter: brightness(.6) contrast(1.2);
8895
}

0 commit comments

Comments
 (0)