Scrub query/fragment from error messages; add href redaction test

Author: taarikashenafi

src/rules/alt-text-quality.ts

@@ -103,7 +103,8 @@ export const altTextQuality: Rule = {
       try {
         dataUrl = await loadImageAsDataUrl(resolved)
       } catch (err) {
-        console.error(`[alt-text-quality] failed to load ${redactUrl(resolved)}:`, err)
+        const msg = (err instanceof Error ? err.message : String(err)).replace(/([?#])[^\s]*/g, '$1…')
+        console.error(`[alt-text-quality] failed to load ${redactUrl(resolved)}: ${redactUrl(msg)}`)
         continue
       }
 
@@ -117,7 +118,8 @@ export const altTextQuality: Rule = {
           naturalHeight: image.naturalHeight,
         })
       } catch (err) {
-        console.error(`[alt-text-quality] judge failed for ${redactUrl(resolved)}:`, err)
+        const msg = (err instanceof Error ? err.message : String(err)).replace(/([?#])[^\s]*/g, '$1…')
+        console.error(`[alt-text-quality] judge failed for ${redactUrl(resolved)}: ${redactUrl(msg)}`)
         continue
       }
 

tests/unit/alt-text-quality.test.ts

@@ -125,4 +125,20 @@ describe('alt-text-quality', () => {
     expect(context).toContain('src="(omitted)"')
     expect(context).toContain('srcset="(omitted)"')
   })
+
+  it('redacts query/fragment from the link href in the judge context', async () => {
+    const fake = new FakeJudge(() => verdict())
+    __setJudge(fake)
+    await run([
+      makeImage({
+        src: DATA_URL,
+        alt: 'a dog',
+        inLink: {href: 'https://example.com/page?sig=secret123#frag'},
+      }),
+    ])
+    const context = fake.calls[0]!.context
+    expect(context).not.toContain('sig=secret123')
+    expect(context).not.toContain('#frag')
+    expect(context).toContain('https://example.com/page')
+  })
 })