Add error message, when dns-persist-01 cannot be created

Author: glatzert

src/ACMEServer.ADCS/ACMEServer.ADCS.csproj

@@ -4,7 +4,7 @@
 		<TargetFrameworks>net8.0-windows;net10.0-windows</TargetFrameworks>
 		<RuntimeIdentifier>win-x64</RuntimeIdentifier>
 		<PlatformTarget>x64</PlatformTarget>
-		<InformationalVersion>3.1.0-beta5</InformationalVersion>
+		<InformationalVersion>3.1.0-beta7</InformationalVersion>
 
 		<Nullable>enable</Nullable>
 		<ImplicitUsings>enable</ImplicitUsings>

src/ACMEServer.Abstractions/LogMessages.cs

@@ -33,6 +33,12 @@ public static partial class LogMessages
         Message = "No challenge types available for identifier {Identifier} and its metadata restrictions {AllowedChallengeTypes}")]
     public static partial void NoChallengeTypesAvailable(this ILogger logger, Identifier identifier, string allowedChallengeTypes);
 
+    [LoggerMessage(
+        EventId = 1002,
+        Level = LogLevel.Warning,
+        Message = "CAA identities are not configured. Cannot create dns-persist-01 challenge.")]
+    public static partial void CAAIdentitiesNotConfigured(this ILogger logger);
+
     #endregion
 
     #region CsrValidator (1020-1049)

src/ACMEServer/Configuration/ACMEServerOptions.cs

@@ -7,7 +7,7 @@ public class ACMEServerOptions
 
     public string? CanonicalHostname { get; set; }
 
-    public string[] CAAIdentities { get; set; } = [];
+    public string[]? CAAIdentities { get; set; }
 
     public string? WebsiteUrl { get; set; }
 

src/ACMEServer/Services/DefaultAuthorizationFactory.cs

@@ -55,6 +55,12 @@ public void CreateAuthorizations(Order order, Dictionary<Identifier, string[]> c
             }
 
             CreateChallenges(authorization, allowedChallengeTypes);
+
+            if (authorization.Challenges.Count == 0)
+             {
+                 _logger.NoChallengeTypesAvailable(authorization.Identifier, string.Join(",", allowedChallengeTypes));
+                 throw AcmeErrors.NoChallengeTypeAvailable(authorization.Identifier, authorization.Order.Profile).AsException();
+             }
         }
     }
 
@@ -76,6 +82,11 @@ private void CreateChallenges(Authorization authorization, List<string> allowedC
             else if (challengeType == ChallengeTypes.DnsPersist01)
             {
                 var accountUri = _linkGenerator.GetAccount(accountId: authorization.Order.AccountId);
+                if ((_serverOptions.Value.CAAIdentities?.Length ?? 0) == 0)
+                {
+                    _logger.CAAIdentitiesNotConfigured();
+                    continue;
+                }
                 _ = new DnsPersistChallenge(authorization, accountUri, _serverOptions.Value.CAAIdentities);
             }
             else if (ChallengeTypes.TokenChallenges.Contains(challengeType)) {