Skip to content

cleanup: merge auxiliary_go123.go contents with auxiliary.go #20229

Description

@noahdietz

At the time Go 1.23 was launched it came with a new iterator pattern. We wanted to start using it, but our min Go version was not Go 1.23, so the generated code to extend our existing generated iterator types had to added to a separate file with a build tag restricting its inclusion to Go 1.23 builds.

The new file was auxiliary_go123.go with a supporting, per-client {client}_example_go123_test.go file for the examples.

Now that the min Go version is beyond Go 1.23, we can merge the contents of these files with our existing auxiliary.go and {client}_example_test.go files.

This will first need a gax-go change to remove the build restriction on the supportingiterator.go file (plus a release and version bump in clients), as well as a gapic-generator-go change to move the generated code into the standard auxiliary.go & example file.

Metadata

Metadata

Assignees

No one assigned

    Labels

    type: cleanupAn internal cleanup or hygiene concern.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions