fix all 12 clippy warnings for clean CI

- empty_line_after_doc_comment: context_pack.rs
- manual_clamp: dag.rs (use .clamp())
- map_entry: dag.rs (use Entry::Vacant)
- type_complexity: db.rs (3 functions)
- needless_borrow: runtime.rs (2 occurrences)
- redundant_closure: replay.rs
- unnecessary_cast: summarizer.rs (2 occurrences)
- private_interfaces: dag.rs (DagGraph -> pub(crate))

Author: gordonlu

.github/workflows/rust.yml

@@ -19,9 +19,7 @@ jobs:
         with:
           components: clippy, rustfmt
       - uses: Swatinem/rust-cache@v2
-      - run: cargo clippy --lib
-        env:
-          RUSTFLAGS: -A warnings
+      - run: cargo clippy --lib -- -D warnings
 
   # Unit tests only (no external dependencies)
   unit-tests:

Cargo.lock

@@ -1,7 +1,6 @@
 /// DS4-14: ContextPack importance ordering.
 /// Wraps messages with computed importance scores and supports
 /// Preserve, ReverseChronological, or ByImportance ordering.
-
 /// 0/1 knapsack selector: given items with value and cost, select the subset
 /// within `capacity` that maximizes total value.
 ///

src/context_pack.rs

@@ -67,7 +67,7 @@ impl KnowledgeDag {
 
 /// In-memory snapshot of a conversation's DAG, used for batch-loaded
 /// context assembly (avoids N+1 DB roundtrips).
-struct DagGraph {
+pub(crate) struct DagGraph {
     nodes: HashMap<i64, DagNode>,
     children: HashMap<i64, Vec<i64>>,
 }
@@ -861,7 +861,7 @@ impl DagEngine {
                 .filter(|sr| sr.source != "message")
                 .filter(|sr| !injected_ids.contains(&sr.id))
                 .map(|sr| {
-                    let semantic = sr.bm25_score.unwrap_or(0.5).min(1.0).max(0.0); // normalize FTS5 rank
+                    let semantic = sr.bm25_score.unwrap_or(0.5).clamp(0.0, 1.0);
                     let dist = distances.get(&sr.id).copied();
                     let recency = if max_id > 0.0 {
                         (sr.id as f64 / max_id).min(1.0)
@@ -948,20 +948,18 @@ impl DagEngine {
 
         while let Some(cur) = queue.pop_front() {
             let d = dist[&cur] + 1;
-            // Walk children (graph.children maps node → its child node IDs)
             if let Some(children) = graph.children.get(&cur) {
                 for &child in children {
-                    if !dist.contains_key(&child) {
-                        dist.insert(child, d);
+                    if let std::collections::hash_map::Entry::Vacant(e) = dist.entry(child) {
+                        e.insert(d);
                         queue.push_back(child);
                     }
                 }
             }
-            // Walk parents (each node's parent_ids field)
             if let Some(node) = graph.nodes.get(&cur) {
                 for &pid in &node.parent_ids {
-                    if !dist.contains_key(&pid) {
-                        dist.insert(pid, d);
+                    if let std::collections::hash_map::Entry::Vacant(e) = dist.entry(pid) {
+                        e.insert(d);
                         queue.push_back(pid);
                     }
                 }

src/dag.rs

@@ -2505,6 +2505,7 @@ impl Database {
     }
 
     /// Get full failure pattern data (with all fields) by signature.
+    #[allow(clippy::type_complexity)]
     pub fn get_failure_pattern_by_signature(
         &self, conv_id: i64, signature: &str,
     ) -> anyhow::Result<Option<(String, String, Vec<String>, String)>> {
@@ -2722,6 +2723,7 @@ impl Database {
     }
 
     /// Query decision records for a conversation (most recent first).
+    #[allow(clippy::type_complexity)]
     pub fn query_decision_records(&self, conv_id: i64, limit: usize) -> anyhow::Result<Vec<(i64, String, f64, Option<bool>, Option<String>, u64, Option<u64>, String)>> {
         let conn = self.read_conn();
         let mut stmt = conn.prepare(
@@ -2832,6 +2834,7 @@ impl Database {
     /// Read all execution events for a replay session (by replay_session_id).
     /// Returns (id, execution_id, event_kind, event_payload, seq_no, created_at, epoch_ms)
     /// ordered by insertion order (id ascending) for deterministic replay.
+    #[allow(clippy::type_complexity)]
     pub fn get_execution_events_by_session(
         &self, session_id: &str,
     ) -> anyhow::Result<Vec<(i64, Option<i64>, String, String, i64, String, i64)>> {

src/db.rs

@@ -550,7 +550,7 @@ pub fn replay_session(
     session_id: &str,
 ) -> Result<ReplayResult, ReplayError> {
     let rows = db.get_execution_events_by_session(session_id)
-        .map_err(|e| ReplayError::Other(e))?;
+        .map_err(ReplayError::Other)?;
     if rows.is_empty() {
         return Ok(ReplayResult { events: vec![], corrupt_count: 0 });
     }

src/replay.rs

@@ -1243,7 +1243,7 @@ impl OnlineEvaluator {
     /// Adjust a candidate's score based on historical success rate.
     /// High success → boost; low success → reduce; unknown → neutral.
     pub fn adjust_score(&self, candidate: &mut DecisionCandidate, rule_name: &str) {
-        let action = &candidate.decision.action.variant_name();
+        let action = candidate.decision.action.variant_name();
         let rate = self.success_rate(action);
         // Blend: final = score * (0.5 + 0.5 * rate)
         // At rate=1.0 → score * 1.0 (no change)
@@ -1475,7 +1475,7 @@ pub fn evaluate_plan_context(
     // Store a decision record so the runtime can track plan-related outcomes
     let _ = db.store_decision_record(
         conv_id,
-        &decision.action.variant_name(),
+        decision.action.variant_name(),
         decision.confidence,
         &decision.reason,
         decision.estimated_token_saving,

src/runtime.rs

@@ -480,7 +480,7 @@ impl Summarizer {
                         }
                     } else if status.as_u16() == 429 {
                         // Rate limited — full-jitter exponential backoff
-                        let delay_ms = crate::runtime::full_jitter_backoff(2000, 60000, attempt as u32, jitter_seed());
+                        let delay_ms = crate::runtime::full_jitter_backoff(2000, 60000, attempt, jitter_seed());
                         let delay = Duration::from_millis(delay_ms);
                         tracing::warn!(
                             target = "deeplossless::summarizer",
@@ -516,7 +516,7 @@ impl Summarizer {
                         "request failed"
                     );
                     if e.is_timeout() || e.is_connect() {
-                        let delay_ms = crate::runtime::full_jitter_backoff(1000, 30000, attempt as u32, jitter_seed());
+                        let delay_ms = crate::runtime::full_jitter_backoff(1000, 30000, attempt, jitter_seed());
                         let delay = Duration::from_millis(delay_ms);
                         tokio::time::sleep(delay).await;
                         last_error = Some(anyhow::anyhow!("{e}"));