Skip to content

Commit 606326e

Browse files
committed
update version
1 parent af2f319 commit 606326e

2 files changed

Lines changed: 7 additions & 6 deletions

File tree

empfin/factor_models.py

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1027,12 +1027,13 @@ def _build_Gamma_hat_rho_l(T, Sbar, wg_hat, V_rho, l):
10271027

10281028
def _get_number_latent_factors(self):
10291029
retp_ret = ((self.assets - self.assets.mean()).T @ (self.assets - self.assets.mean())).values
1030-
eigv = np.sort(eigvals(retp_ret))[::-1]
1031-
gamma_hat = np.median(eigv[:self.k_max])
1030+
eigv = np.sort(eigvals(retp_ret).real)[::-1]
1031+
eigv_normalized = eigv / (self.t * self.n)
1032+
gamma_hat = np.median(eigv_normalized[:self.k_max])
10321033
phi_nt = 0.5 * gamma_hat * np.log(self.t * self.n) * (self.t ** (-0.5) + self.n ** (-0.5))
1033-
j = (np.arange(len(eigv)) + 1)
1034-
grid = (eigv / (self.t * self.n)) + j * phi_nt
1035-
k_hat = np.argmin(grid) + 1
1034+
j = np.arange(1, self.k_max + 1)
1035+
grid = eigv_normalized[:self.k_max] + j * phi_nt
1036+
k_hat = max(1, np.argmin(grid))
10361037
print("selected number of factors is", k_hat)
10371038
return k_hat
10381039

setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
with codecs.open(os.path.join(here, "README.md"), encoding="utf-8") as fh:
88
long_description = "\n" + fh.read()
99

10-
VERSION = '1.9'
10+
VERSION = '1.10'
1111
DESCRIPTION = 'Empirical Finance Tools'
1212

1313
# Setting up

0 commit comments

Comments
 (0)