Skip to content

Commit e1f2e89

Browse files
authored
feat: remove deprecated zipkin tracer (#319)
1 parent 877cdc1 commit e1f2e89

File tree

5 files changed

+3
-20
lines changed

5 files changed

+3
-20
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -168,7 +168,7 @@ The tracing flags are used by `cmd.NewTracer` to create a new open telemetry `tr
168168

169169
#### FlagTracingExporter: *--tracing.exporter, $TRACING_EXPORTER*
170170

171-
This flag sets the exporter to send spans to. The available options are `zipkin`, `otlphttp` and `otlpgrpc`.
171+
This flag sets the exporter to send spans to. The available options are `otlphttp` and `otlpgrpc`.
172172

173173
Example: `--tracing.exporter=otlphttp`
174174

go.mod

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ require (
1616
go.opentelemetry.io/otel v1.39.0
1717
go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc v1.39.0
1818
go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp v1.39.0
19-
go.opentelemetry.io/otel/exporters/zipkin v1.39.0
2019
go.opentelemetry.io/otel/sdk v1.39.0
2120
go.opentelemetry.io/otel/trace v1.39.0
2221
)
@@ -38,7 +37,6 @@ require (
3837
github.com/mattn/go-colorable v0.1.14 // indirect
3938
github.com/mattn/go-isatty v0.0.20 // indirect
4039
github.com/munnerz/goautoneg v0.0.0-20191010083416-a7dc8b61c822 // indirect
41-
github.com/openzipkin/zipkin-go v0.4.3 // indirect
4240
github.com/pmezard/go-difflib v1.0.0 // indirect
4341
github.com/prometheus/client_golang v1.23.2 // indirect
4442
github.com/prometheus/client_model v0.6.2 // indirect

go.sum

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -57,8 +57,6 @@ github.com/mattn/go-isatty v0.0.20 h1:xfD0iDuEKnDkl03q4limB+vH+GxLEtL/jb4xVJSWWE
5757
github.com/mattn/go-isatty v0.0.20/go.mod h1:W+V8PltTTMOvKvAeJH7IuucS94S2C6jfK/D7dTCTo3Y=
5858
github.com/munnerz/goautoneg v0.0.0-20191010083416-a7dc8b61c822 h1:C3w9PqII01/Oq1c1nUAm88MOHcQC9l5mIlSMApZMrHA=
5959
github.com/munnerz/goautoneg v0.0.0-20191010083416-a7dc8b61c822/go.mod h1:+n7T8mK8HuQTcFwEeznm/DIxMOiR9yIdICNftLE1DvQ=
60-
github.com/openzipkin/zipkin-go v0.4.3 h1:9EGwpqkgnwdEIJ+Od7QVSEIH+ocmm5nPat0G7sjsSdg=
61-
github.com/openzipkin/zipkin-go v0.4.3/go.mod h1:M9wCJZFWCo2RiY+o1eBCEMe0Dp2S5LDHcMZmk3RmK7c=
6260
github.com/pmezard/go-difflib v1.0.0 h1:4DBwDE0NGyQoBHbLQYPwSUPoCMWR5BEzIk/f1lZbAQM=
6361
github.com/pmezard/go-difflib v1.0.0/go.mod h1:iKH77koFhYxTK1pcRnkKkqfTogsbg7gZNVY4sRDYZ/4=
6462
github.com/prometheus/client_golang v1.23.2 h1:Je96obch5RDVy3FDMndoUsjAhG5Edi49h0RJWRi/o0o=
@@ -98,8 +96,6 @@ go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc v1.39.0 h1:in9O8
9896
go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc v1.39.0/go.mod h1:Rp0EXBm5tfnv0WL+ARyO/PHBEaEAT8UUHQ6AGJcSq6c=
9997
go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp v1.39.0 h1:Ckwye2FpXkYgiHX7fyVrN1uA/UYd9ounqqTuSNAv0k4=
10098
go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp v1.39.0/go.mod h1:teIFJh5pW2y+AN7riv6IBPX2DuesS3HgP39mwOspKwU=
101-
go.opentelemetry.io/otel/exporters/zipkin v1.39.0 h1:zas8I6MeDWD5rxJmkXcCPRnpvNtZHkENiTkX/eJlycg=
102-
go.opentelemetry.io/otel/exporters/zipkin v1.39.0/go.mod h1:SmFF1H2pTNFFvD4NqRanxPP8W+8KjTgFJhJQi3C6Co0=
10399
go.opentelemetry.io/otel/metric v1.21.0/go.mod h1:o1p3CA8nNHW8j5yuQLdc1eeqEaPfzug24uvsyIEJRWM=
104100
go.opentelemetry.io/otel/metric v1.39.0 h1:d1UzonvEZriVfpNKEVmHXbdf909uGTOQjA0HF0Ls5Q0=
105101
go.opentelemetry.io/otel/metric v1.39.0/go.mod h1:jrZSWL33sD7bBxg1xjrqyDjnuzTUB0x1nBERXd7Ftcs=

trace.go

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ import (
1212
"go.opentelemetry.io/otel/attribute"
1313
"go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc"
1414
"go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp"
15-
"go.opentelemetry.io/otel/exporters/zipkin"
1615
"go.opentelemetry.io/otel/sdk/resource"
1716
"go.opentelemetry.io/otel/sdk/trace"
1817
semconv "go.opentelemetry.io/otel/semconv/v1.24.0"
@@ -36,7 +35,7 @@ var TracingFlags = Flags{
3635
&cli.StringFlag{
3736
Name: FlagTracingExporter,
3837
Category: CategoryTracing,
39-
Usage: "The tracing backend. Supported: 'zipkin', 'otlphttp', 'otlpgrpc'.",
38+
Usage: "The tracing backend. Supported: 'otlphttp', 'otlpgrpc'.",
4039
Sources: cli.EnvVars(strcase.ToSNAKE(FlagTracingExporter)),
4140
},
4241
&cli.StringFlag{
@@ -109,8 +108,6 @@ func createExporter(ctx context.Context, cmd *cli.Command) (trace.SpanExporter,
109108
switch backend {
110109
case "":
111110
return nil, nil //nolint:nilnil
112-
case "zipkin":
113-
return zipkin.New(endpoint)
114111
case "otlphttp":
115112
opts := []otlptracehttp.Option{otlptracehttp.WithEndpoint(endpoint), otlptracehttp.WithHeaders(cmd.StringMap(FlagTracingHeaders))}
116113
if cmd.Bool(FlagTracingEndpointInsecure) {

trace_test.go

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -25,14 +25,6 @@ func TestNewTracer(t *testing.T) {
2525
args: []string{},
2626
wantErr: assert.NoError,
2727
},
28-
{
29-
name: "zipkin",
30-
args: []string{
31-
"--tracing.exporter=zipkin",
32-
"--tracing.endpoint=http://localhost:1234/api/v2",
33-
},
34-
wantErr: assert.NoError,
35-
},
3628
{
3729
name: "otelhttp",
3830
args: []string{
@@ -52,7 +44,7 @@ func TestNewTracer(t *testing.T) {
5244
{
5345
name: "with tags",
5446
args: []string{
55-
"--tracing.exporter=zipkin",
47+
"--tracing.exporter=otlphttp",
5648
"--tracing.endpoint=http://localhost:1234/api/v2",
5749
"--tracing.ratio=1",
5850
"--tracing.tags=cluster=test",

0 commit comments

Comments
 (0)