From 403472c84e1226df8e05e3b974334f56252ff0f8 Mon Sep 17 00:00:00 2001 From: Kokhong Cheng Date: Wed, 6 Jan 2021 23:15:53 +0800 Subject: [PATCH] browser: fix return nil forms Appending to an allocated slice would start appending past the last index, leading to the first len items being nil. --- browser/browser.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/browser/browser.go b/browser/browser.go index 0632bdd..d8c763f 100644 --- a/browser/browser.go +++ b/browser/browser.go @@ -378,7 +378,7 @@ func (bow *Browser) Forms() []Submittable { return nil } - forms := make([]Submittable, len) + var forms []Submittable sel.Each(func(_ int, s *goquery.Selection) { forms = append(forms, NewForm(bow, s)) })