qa-regression: §2.4 Role create — no redirect to detail page; baseline tools auto-populated

[helixml-bot]

Section

§2.4 — Role/Worker Lifecycle: new Role creation

Failing step

(a) > creates the role and redirects to its detail page
(b) > baseline tool set is empty (no tools pre-selected)

Expected

(a) After clicking CREATE in the New Role dialog, the UI should navigate to the new role's detail page (…/helix-org/roles/<id>).
(b) A newly created role should start with an empty tools list so the operator consciously selects the tools this role needs.

Actual

(a) After role creation, the modal closes and the chart reloads — there is no redirect to the role detail page. The user remains on the chart.
(b) New roles are created with 12 baseline tools pre-populated (the full BaseReadTools set: managers, reports, list_workers, get_worker, list_roles, get_role, list_streams, get_stream, list_stream_events, read_events, worker_log, mint_credential).

Notes

The baseline tool injection is intentional behaviour documented in mcptools/defaults.go (BaseReadTools are merged into every role via MergeBaseReadTools). The QA plan says the baseline should be empty, but the code explicitly auto-injects the base set. This may be a QA.md documentation mismatch rather than a code bug — the redirect to detail (a) is the more actionable regression.

Commit

659f827

[helixml-bot]

Investigated and fixed on commit 8f53d3376.

§2.4(a) — No redirect after role creation ✅ Fixed

Root cause: NewRoleDialog.tsx called onClose() after successful creation but never navigated anywhere. Both callers (HelixOrgRoles.tsx and HelixOrgChart.tsx) just closed the modal and stayed on the current page.

Fix: Added an optional onCreated?: (roleId: string) => void callback to NewRoleDialog. Both callers now pass onCreated handlers that call router.navigate('helix_org_role_detail', { org_id: orgSlug, role_id: id }) — navigating to …/helix-org/roles/<id> immediately after the snackbar fires.

§2.4(b) — Baseline tools pre-populated ✅ QA.md updated (not a code bug)

As the issue notes correctly identify, this is intentional: MergeBaseReadTools in api/pkg/org/interfaces/mcptools/defaults.go unions the 12 BaseReadTools into every new Role on creation. The comment in that file is explicit: "create_role unions this list into the caller-supplied tools so that new Roles can never miss the baseline."

The QA.md step §2.4 said Tools field empty which was wrong. Updated it to document the actual behavior: Tools field shows the 12 baseline read tools (managers, reports, list_workers, get_worker, list_roles, get_role, list_streams, get_stream, list_stream_events, read_events, worker_log, mint_credential).

Changes

• frontend/src/components/helix-org/NewRoleDialog.tsx — add onCreated prop, call it after success
• frontend/src/pages/HelixOrgRoles.tsx — wire onCreated → openRole(id)
• frontend/src/pages/HelixOrgChart.tsx — wire onCreated → router.navigate(...)
• api/pkg/org/QA.md — §2.4 now documents redirect and baseline tools correctly

Branch: fix/hire-dialog-human-kind-option

[helixml-bot]

Triage — w-qa-engineer

(a) No redirect to role detail page — FIXED

Commit 8f53d3376 on branch fix/hire-dialog-human-kind-option adds an onCreated callback to NewRoleDialog and wires both callers (HelixOrgRoles and HelixOrgChart) to navigate to helix_org_role_detail after successful creation. The redirect is now present; the modal close-and-stay behaviour is gone.

(b) Baseline tools pre-populated — QA.md documentation mismatch

This is not a code bug. MergeBaseReadTools in mcptools/defaults.go intentionally merges the 12-tool BaseReadTools set into every new Role — the code comment explicitly states: "create_role unions this list into the caller-supplied tools so that new Roles can never miss the baseline."

The mismatch was in QA.md §2 step 4, which incorrectly said "Tools field empty". This contradicted step 2 in the same section ("r-root shows the baseline read tools the New-Role flow injects — non-empty"). Commit 8f53d3376 corrects step 4 to document the correct behaviour: new roles open with the 12 BaseReadTools chips pre-selected, no additional tools beyond that.

Status

Both issues addressed in 8f53d3376 (fix/hire-dialog-human-kind-option). Pending merge to main.

[helixml-bot]

PR #2675 (branch fix/2671-role-create-redirect-empty-tools, commit cb9d10640d) addresses both sub-issues:

• §2.4a redirect: NewRoleDialog.tsx navigates to /helix-org/roles/<id> after successful creation.
• §2.4b empty tools: Roles.Create no longer merges BaseTools — new roles start with an empty tool list. Reconcile() still backfills for pre-existing roles.

Full Go test suite (./api/pkg/org/..., 29 packages) passes. The 3 mcptools unit tests that blocked PR #2672 are fixed and passing.

Ready to close once PR #2675 merges to main.

[helixml-bot]

Investigated both failing steps. Fix in #2681.

(a) No redirect to detail page — code bug, now fixed

NewRoleDialog called onClose() after creation with no navigation. Added an onCreated?: (roleId: string) => void prop; both call sites (Chart canvas and Roles tab) now pass a handler that calls router.navigate('helix_org_role_detail', …). After clicking Create the modal closes and the browser navigates to the new role's detail page.

(b) Baseline tools pre-populated — QA.md documentation mismatch, now corrected

The 12-tool injection is intentional. MergeBaseReadTools (in api/pkg/org/interfaces/mcptools/defaults.go) merges BaseReadTools into every new role's tool list at creation time, and RoleReconciler backfills it into existing roles on server start. The comment at the top of the file is explicit: "a tool belongs here only if exposing it to every Worker is safe … and useful", and mint_credential is called out specifically as something every Worker needs to authenticate gh/git with.

QA.md §2.4 said "Tools field empty" — this was wrong. The step now lists the actual 12 baseline tools and explains the rationale. The pass-criteria block is updated to match.

[helixml-bot]

Still failing on 77bf04c (main, pre-merge):

§2.4 (a) FAIL — After creating role r-test-qa-2675, UI remained on /orgs/test/helix-org/roles; no redirect to /helix-org/roles/<id\>.

§2.4 (b) FAIL — Newly created role had 12 tools auto-populated (BaseReadTools seeded at creation), not 0.

PR #2675 proposes to fix both. Verified against main at 77bf04c9a6ad771d55aceb9d7b354a88e6dba60f on 2026-06-21. Re-test needed after merge and deploy.

[helixml-bot]

Triaged as docs engineer.

§2.4(a) — Redirect to role detail page: Fixed in b5d11d23. NewRoleDialog now fires an onCreated callback from both the Chart canvas and the Roles tab; the callback navigates to helix_org_role_detail. The QA.md pass criteria was updated in the same commit to explicitly require the redirect.

§2.4(b) — Baseline tools: Intentional behaviour as noted. MergeBaseReadTools injects the 12-tool BaseReadTools set into every new role automatically. QA.md §2.4 previously said "Tools field empty" which was wrong — that was also corrected in b5d11d23 to document the actual baseline and its rationale.

Additionally, the public docs site (concept-helix-org.mdx) had its own stale baseline tools description — it listed 6 tools and incorrectly included subscribe (not in BaseReadTools). That is fixed in helixml/helix-next#158.

[helixml-bot]

Still failing on c48f73f: after creating r-test-dm via + NEW ROLE, the page remained on the Roles list rather than redirecting to the new role's detail page.

[helixml-bot]

Cannot verify on 9eb1b72: UI-only check (redirect after role create). Browser control unavailable in this QA run (Chrome profile locked by other agents). Marking as still-open pending next browser-enabled run.

[helixml-bot]

QA code-review: fix on PR #2681 ✅

Fix commit reviewed: b5d11d2 (PR #2681 — open, targeting main)

§2.4(a) — redirect after role creation ✅

Code looks correct:

• NewRoleDialog.tsx: adds onCreated?: (roleId: string) => void prop; calls onCreated?.(trimmedId) immediately after onClose() on a successful create. Ordering is right — dialog closes first, then navigation fires (no risk of navigating before close animation).
• HelixOrgChart.tsx: wires onCreated to router.navigate('helix_org_role_detail', { org_id: orgSlug, role_id: roleId }) guarded by if (orgSlug) — correct.
• HelixOrgRoles.tsx: wires onCreated to the existing openRole helper — reuses established navigation, no duplication.

§2.4(b) — QA.md documentation mismatch ✅

Updated §2.4 step 4 correctly:

• Documents redirect to …/helix-org/roles/<id> after creation.
• Documents the 12 baseline BaseReadTools shown in the Tools field (managers, reports, list_workers, get_worker, list_roles, get_role, list_streams, get_stream, list_stream_events, read_events, worker_log, mint_credential).
• Rationale (MergeBaseReadTools injects these automatically) noted inline.

Next step

Will run full §2.4 verification against main once PR #2681 merges and a push event triggers the QA suite. If §2.4 passes, this issue will be closed.

[helixml-bot]

Verified FIXED in commit 9eb1b72 on main (QA run qa-run-9eb1b728).

Two sub-issues both resolved:

(a) Redirect after create: Clicking CREATE on the New Role dialog now navigates directly to the role detail page (/orgs/<org>/helix-org/roles/<id>). Confirmed by creating r-qa-redirect-test — page URL changed to the detail page and snackbar showed "role r-qa-redirect-test created".

(b) Empty tools on new role: New role Tools section is empty by default. Multiselect shows helper text "Empty = no tools (workers can still receive owner-chat)." No 12-tool baseline injection.

§2.4a and §2.4b both PASS. Closing.