Skip to content

Commit 2178e6d

Browse files
committed
functional-tests: remove outdated tests that do not use internal fields
The test case called 'internalFieldOfStructCanBeAccessed' initially used internal fields, but the usage was removed when it stopped to compile. The fields 'someInteger' and 'someLong' are public in public type: ``` struct SomeStructWithInternalMembers { someInteger: Int someLong: Long ``` Signed-off-by: Patryk Wrobel <183546751+pwrobeldev@users.noreply.github.com>
1 parent 058c0ab commit 2178e6d

1 file changed

Lines changed: 4 additions & 12 deletions

File tree

functional-tests/functional/android/src/test/java/com/here/android/test/VisibilityAttributeTest.java

Lines changed: 4 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -40,16 +40,11 @@ public void internalConstructorOfClassCanBeCalled() {
4040
SomeClassWithInternalMembers someObject = new SomeClassWithInternalMembers();
4141
}
4242

43-
@Test
44-
public void internalFieldOfStructCanBeAccessed() {
45-
SomeStructWithInternalMembers someObject = new SomeStructWithInternalMembers(21);
46-
assertEquals(21, someObject.someInteger);
47-
assertEquals(444, someObject.someLong);
48-
}
49-
5043
@Test
5144
public void internalFreeArgsCtorCanBeCalled() {
5245
SomeStructWithInternalFreeArgsCtor someObject = new SomeStructWithInternalFreeArgsCtor(33);
46+
47+
// Note: 'someObject.someString' is a public field of public structure.
5348
assertEquals("Special string", someObject.someString);
5449
}
5550

@@ -61,6 +56,8 @@ public void internalAllArgsCtorCanBeCalled() {
6156
@Test
6257
public void internalFieldCtorCanBeCalled() {
6358
SomeStructWithInternalFieldConstructor someObject = new SomeStructWithInternalFieldConstructor(77);
59+
60+
// Note: 'someObject.someString' is a public field of public structure.
6461
assertEquals("QAZWSX", someObject.someString);
6562
}
6663

@@ -70,11 +67,6 @@ public void valueOfInternalEnumCanBeAccessed() {
7067
assertEquals(SomeInternalEnum.TWO, someObject);
7168
}
7269

73-
@Test
74-
public void internaInterfaceFromJavaCanBeUsed() {
75-
SomeStructWithInternalMembers someObject = new SomeStructWithInternalMembers(21);
76-
}
77-
7870
@Test
7971
public void internalExceptionCanBeThrown() {
8072
SomethingBadHappenedException exception = assertThrows(SomethingBadHappenedException.class, () -> {

0 commit comments

Comments
 (0)