Minor fixes

Author: vtm9

apps/codebattle/lib/codebattle_web/channels/game_channel.ex

@@ -282,86 +282,6 @@ defmodule CodebattleWeb.GameChannel do
     {:reply, {:ok, %{head_to_head: head_to_head}}, socket}
   end
 
-  defp assign_editor_summary_rate_limit(socket) do
-    now_ms = System.monotonic_time(:millisecond)
-
-    assign(socket, :editor_summary_rate_limit, %{
-      window_started_at_ms: now_ms,
-      summary_count: 0,
-      event_count: 0
-    })
-  end
-
-  defp allow_editor_summary?(socket, summary_event_count) do
-    now_ms = System.monotonic_time(:millisecond)
-    state = socket.assigns[:editor_summary_rate_limit] || %{}
-    window_started_at_ms = Map.get(state, :window_started_at_ms, now_ms)
-
-    state =
-      if now_ms - window_started_at_ms >= @telemetry_limit_window_ms do
-        %{
-          window_started_at_ms: now_ms,
-          summary_count: 0,
-          event_count: 0
-        }
-      else
-        state
-      end
-
-    next_summary_count = Map.get(state, :summary_count, 0) + 1
-    next_event_count = Map.get(state, :event_count, 0) + summary_event_count
-
-    if next_summary_count > @max_editor_summaries_per_window ||
-         next_event_count > @max_editor_summary_events_per_window do
-      {:error, :editor_summary_rate_limited}
-    else
-      {:ok,
-       assign(socket, :editor_summary_rate_limit, %{
-         state
-         | summary_count: next_summary_count,
-           event_count: next_event_count
-       })}
-    end
-  end
-
-  defp parse_editor_summary_payload(payload) do
-    summary = payload["summary"] || %{}
-
-    %{
-      summary: summary,
-      lang_slug: payload["lang_slug"] || payload["langSlug"],
-      summary_event_count: normalize_non_negative_integer(summary["event_count"] || summary["eventCount"])
-    }
-  end
-
-  defp store_editor_summary(socket, summary, lang_slug) do
-    game_id = socket.assigns.game_id
-    user = socket.assigns.current_user
-
-    case Context.store_editor_summary(game_id, user, summary, lang_slug) do
-      {:ok, _result} ->
-        {:noreply, socket}
-
-      {:error, %Ecto.Changeset{} = changeset} ->
-        Logger.warning("Failed to persist editor summary: #{inspect(changeset.errors)}")
-        {:reply, {:error, %{reason: :invalid_editor_summary}}, socket}
-
-      {:error, reason} ->
-        {:reply, {:error, %{reason: reason}}, socket}
-    end
-  end
-
-  defp normalize_non_negative_integer(value) when is_integer(value) and value >= 0, do: value
-
-  defp normalize_non_negative_integer(value) when is_binary(value) do
-    case Integer.parse(value) do
-      {integer, ""} when integer >= 0 -> integer
-      _ -> 0
-    end
-  end
-
-  defp normalize_non_negative_integer(_value), do: 0
-
   def handle_in("rematch:send_offer", _, socket) do
     game_id = socket.assigns.game_id
     user = socket.assigns.current_user
@@ -471,6 +391,86 @@ defmodule CodebattleWeb.GameChannel do
     {:noreply, socket}
   end
 
+  defp assign_editor_summary_rate_limit(socket) do
+    now_ms = System.monotonic_time(:millisecond)
+
+    assign(socket, :editor_summary_rate_limit, %{
+      window_started_at_ms: now_ms,
+      summary_count: 0,
+      event_count: 0
+    })
+  end
+
+  defp allow_editor_summary?(socket, summary_event_count) do
+    now_ms = System.monotonic_time(:millisecond)
+    state = socket.assigns[:editor_summary_rate_limit] || %{}
+    window_started_at_ms = Map.get(state, :window_started_at_ms, now_ms)
+
+    state =
+      if now_ms - window_started_at_ms >= @telemetry_limit_window_ms do
+        %{
+          window_started_at_ms: now_ms,
+          summary_count: 0,
+          event_count: 0
+        }
+      else
+        state
+      end
+
+    next_summary_count = Map.get(state, :summary_count, 0) + 1
+    next_event_count = Map.get(state, :event_count, 0) + summary_event_count
+
+    if next_summary_count > @max_editor_summaries_per_window ||
+         next_event_count > @max_editor_summary_events_per_window do
+      {:error, :editor_summary_rate_limited}
+    else
+      {:ok,
+       assign(socket, :editor_summary_rate_limit, %{
+         state
+         | summary_count: next_summary_count,
+           event_count: next_event_count
+       })}
+    end
+  end
+
+  defp parse_editor_summary_payload(payload) do
+    summary = payload["summary"] || %{}
+
+    %{
+      summary: summary,
+      lang_slug: payload["lang_slug"] || payload["langSlug"],
+      summary_event_count: normalize_non_negative_integer(summary["event_count"] || summary["eventCount"])
+    }
+  end
+
+  defp store_editor_summary(socket, summary, lang_slug) do
+    game_id = socket.assigns.game_id
+    user = socket.assigns.current_user
+
+    case Context.store_editor_summary(game_id, user, summary, lang_slug) do
+      {:ok, _result} ->
+        {:noreply, socket}
+
+      {:error, %Ecto.Changeset{} = changeset} ->
+        Logger.warning("Failed to persist editor summary: #{inspect(changeset.errors)}")
+        {:reply, {:error, %{reason: :invalid_editor_summary}}, socket}
+
+      {:error, reason} ->
+        {:reply, {:error, %{reason: reason}}, socket}
+    end
+  end
+
+  defp normalize_non_negative_integer(value) when is_integer(value) and value >= 0, do: value
+
+  defp normalize_non_negative_integer(value) when is_binary(value) do
+    case Integer.parse(value) do
+      {integer, ""} when integer >= 0 -> integer
+      _ -> 0
+    end
+  end
+
+  defp normalize_non_negative_integer(_value), do: 0
+
   def handle_info(%{event: "user:banned", payload: %{player: player}}, socket) do
     user_id = socket.assigns.current_user.id
 

apps/codebattle/priv/gettext/ru/LC_MESSAGES/default.po

@@ -322,9 +322,6 @@ msgstr "Тесты"
 msgid "Send"
 msgstr "Отправить"
 
-msgid "Notification"
-msgstr "Нотификация"
-
 msgid "Run"
 msgstr "Запустить"