Conversation
Deploying hyperterminal with
|
| Latest commit: |
ef4ecb9
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d8f7d5ab.hyperterminal.pages.dev |
| Branch Preview URL: | https://small-fixes.hyperterminal.pages.dev |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the faucet mechanism to use Privy authentication instead of Turnstile, adjusts the faucet claim amount to 50 USDH, updates the project's fee rate configuration, and modifies the default selected market. I have reviewed the changes and found that the comment in src/config/hyperliquid.ts needs to be updated to accurately reflect the new fee rate value of 0.003%.
| export const DEFAULT_BUILDER_CONFIG: BuilderConfig = { | ||
| b: "0xe2E7BFE54DDfe5983807C187A57A939C33Eaeb2e", // builder | ||
| f: 1, // fee rate 0.001% | ||
| f: 3, // fee rate 0.001% |
There was a problem hiding this comment.
The value of f has been updated from 1 to 3, but the accompanying comment still states a fee rate 0.001%. To avoid confusion and ensure the configuration is clear, please update the comment to reflect the new value. Assuming a linear relationship, the fee rate would now be 0.003%.
Suggested change
| f: 3, // fee rate 0.001% | |
| f: 3, // fee rate 0.003% |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.