Skip to content

[Bug]: Activating a bang trims whitespace around query #726

Description

@bbb651

Operating system

Linux

Version

Version 0.7.9.1 (Official Build, Chromium 143.0.7499.169) Arch Linux (64-bit)

Have you tested that this is not an upstream issue or an issue with your configuration?

  • I have tried reproducing this issue in Chrome and it could not be reproduced there
  • I have tried reproducing this issue in ungoogled-chromium and it could not be reproduced there
  • I have tried reproducing this issue in Helium with a new and empty profile using --user-data-dir command line argument and it could not be reproduced there

Description

Activating a bang trims whitespace around query, breaking bangs in middle of query compared to search engine bangs

How to Reproduce?

  1. Start typing a search query: helium
  2. Add a bang while in the middle of a search: helium !g
  3. Activate the bang with Space
  4. Continue with the query: browser

Actual behavior

Activating the bang trims the query after removing the bang, deleting the space before between helium and !g leaving you with:

Image

Expected behavior

Image

This is the behavior you get with the same input using search engine bangs like DuckDuckGo: helium !g browser

Additional context

This does not affect usage of bangs in the start or end of the query, since there would be no whitespace to trim or nothing more to add to the query receptively.

P.S. "Have you tested that this is not an upstream issue or an issue with your configuration?" is not applicable here since it's a helium feature (and already tested with an empty profile).

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugSomething isn't workingconfirmedBug is reproducible

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions