Skip to content

CI broken on main: cargo fmt + clippy failures block every open PR #15

Description

@johnintuit

main currently fails both CI gates (cargo fmt --all -- --check and cargo clippy --all-targets -- -D warnings), which blocks CI on every open PR regardless of what that PR actually changes — confirmed on PR #14, whose diff is doc-only (.md/.mdc files) and doesn't touch any of the failing files.

  1. Formatting drift — cargo fmt --all -- --check

76 diffs across 12 files, all from recent remote/Neo4j/pgvector work:

  • crates/infigraph-cli/src/info_commands.rs
  • crates/infigraph-core/src/graph/neo4j_backend.rs
  • crates/infigraph-core/src/lib.rs
  • crates/infigraph-core/src/meta/postgres_store.rs
  • crates/infigraph-core/src/multi/mod.rs
  • crates/infigraph-core/tests/namespace_prefix.rs
  • crates/infigraph-core/tests/neo4j_backend.rs
  • crates/infigraph-core/tests/postgres_registry.rs
  • crates/infigraph-docs/tests/remote_doc_embeddings.rs
  • crates/infigraph-mcp/src/tools/groups.rs
  • crates/infigraph-mcp/src/tools/search.rs

Fix: cargo fmt --all (mechanical, no logic change).

  1. Clippy errors — cargo clippy --all-targets -- -D warnings

Two clippy::type_complexity errors that fail the build outright:

error: very complex type used. Consider factoring parts into type definitions
--> crates/infigraph-mcp/src/tools/search.rs:134:6
134 | ) -> Result<(Vec<Vec>, Vec<(String, Vec)>)> {

error: very complex type used. Consider factoring parts into type definitions
--> crates/infigraph-mcp/src/tools/search.rs:173:32
173 | fn get_search_data_remote() -> Result<(Vec<Vec>, Vec<(String, Vec)>)> {

Fix: introduce a type alias for the (Vec<Vec>, Vec<(String, Vec)>) tuple used by both signatures.

Impact

Any PR opened against current main — including ones with zero Rust changes — shows a red CI check unrelated to that PR's diff. Recommend fixing both as a small, isolated PR before/alongside merging anything else.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

Fields

No fields configured for Bug.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions