Skip to content

Commit ce3a0a8

Browse files
committed
Changes requested for tests
1 parent 8913885 commit ce3a0a8

File tree

1 file changed

+4
-11
lines changed

1 file changed

+4
-11
lines changed

core/src/components/textarea/test/rows/textarea.e2e.ts

Lines changed: 4 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -7,23 +7,20 @@ import { configs, test } from '@utils/test/playwright';
77
*/
88
configs({ modes: ['ionic-md'], directions: ['ltr'] }).forEach(({ title, screenshot, config }) => {
99
test.describe(title('textarea: rows'), () => {
10-
test('should respect rows attribute with different values', async ({ page }) => {
10+
test('should respect rows attribute', async ({ page }) => {
1111
await page.setContent(
1212
`
1313
<div id="container" style="display: flex; flex-direction: column; gap: 20px;">
14-
<h2>Rows: 1</h2>
1514
<ion-textarea
1615
rows="1"
1716
label="Small"
1817
value="1&#10;2&#10;3&#10;4&#10;5&#10;6&#10;7&#10;8&#10;9&#10;0"
1918
></ion-textarea>
20-
<h2>Rows: 3</h2>
2119
<ion-textarea
2220
rows="3"
2321
label="Medium"
2422
value="1&#10;2&#10;3&#10;4&#10;5&#10;6&#10;7&#10;8&#10;9&#10;0"
2523
></ion-textarea>
26-
<h2>Rows: 8</h2>
2724
<ion-textarea
2825
rows="8"
2926
label="Large"
@@ -35,28 +32,25 @@ configs({ modes: ['ionic-md'], directions: ['ltr'] }).forEach(({ title, screensh
3532
);
3633

3734
const container = page.locator('#container');
38-
await expect(container).toHaveScreenshot(screenshot(`textarea-rows-different-values`));
35+
await expect(container).toHaveScreenshot(screenshot(`textarea-rows`));
3936
});
4037

41-
test('should respect rows attribute with different sizes', async ({ page }) => {
38+
test('should respect rows attribute', async ({ page }) => {
4239
await page.setContent(
4340
`
4441
<div id="container" style="display: flex; flex-direction: column; gap: 20px;">
45-
<h2>Rows: 3, Size Small</h2>
4642
<ion-textarea
4743
rows="3"
4844
size="small"
4945
label="Small Size"
5046
value="1&#10;2&#10;3&#10;4&#10;5&#10;6&#10;7&#10;8&#10;9&#10;0"
5147
></ion-textarea>
52-
<h2>Rows: 3, Size Medium</h2>
5348
<ion-textarea
5449
rows="3"
5550
size="medium"
5651
label="Medium Size"
5752
value="1&#10;2&#10;3&#10;4&#10;5&#10;6&#10;7&#10;8&#10;9&#10;0"
5853
></ion-textarea>
59-
<h2>Rows: 3, Size Large</h2>
6054
<ion-textarea
6155
rows="3"
6256
size="large"
@@ -69,14 +63,13 @@ configs({ modes: ['ionic-md'], directions: ['ltr'] }).forEach(({ title, screensh
6963
);
7064

7165
const container = page.locator('#container');
72-
await expect(container).toHaveScreenshot(screenshot(`textarea-rows-different-sizes`));
66+
await expect(container).toHaveScreenshot(screenshot(`textarea-rows-sizes`));
7367
});
7468

7569
test('should respect rows when auto-grow is enabled', async ({ page }) => {
7670
await page.setContent(
7771
`
7872
<div id="container" style="display: flex; flex-direction: column; gap: 20px;">
79-
<h2>Rows: 3, Auto-grow</h2>
8073
<ion-textarea
8174
rows="3"
8275
auto-grow="true"

0 commit comments

Comments
 (0)