Sensor name from config.ini is ignored

[frennkie]

Doesn't this line

RPi-Reporter-MQTT2HA-Daemon/ISP-RPi-mqtt-daemon.py

Line 1239 in 259e42c

sensor_name = 'rpi-{}'.format(rpi_hostname)

defeat the purpose of line

RPi-Reporter-MQTT2HA-Daemon/ISP-RPi-mqtt-daemon.py

Line 265 in 259e42c

sensor_name = os.environ.get(

If the config file specifies a sensor_name then the sensor should get that name - and not use the rpi_hostname (discovered in getHostnames())

[bsimmo]

Not looked, but maybe it is time to spin this into another fork to continue development if people are still using it, move it up to PEP standards and newer Pythons and take the version checks out etc.

…

On Sun, 10 Aug 2025, 12:08 pm frennkie, ***@***.***> wrote: *frennkie* created an issue (ironsheep/RPi-Reporter-MQTT2HA-Daemon#167) <#167> Doesn't this line https://github.com/ironsheep/RPi-Reporter-MQTT2HA-Daemon/blob/259e42c1faa349ebcdcfc7106751c5326cd394f1/ISP-RPi-mqtt-daemon.py#L1239 defeat the purpose of line https://github.com/ironsheep/RPi-Reporter-MQTT2HA-Daemon/blob/259e42c1faa349ebcdcfc7106751c5326cd394f1/ISP-RPi-mqtt-daemon.py#L265 If the config file specifies a sensor_name then the sensor should get that name - and not use the rpi_hostname (discovered in getHostnames()) — Reply to this email directly, view it on GitHub <#167>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACYAXN5ZBL3XRVQVZVI3EE33M4R4DAVCNFSM6AAAAACDREBPJSVHI2DSMVQWIX3LMV43ASLTON2WKOZTGMYDONBWGMYDQNY> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[frennkie]

I did a reformat to make this comply with most (if not all the PEPs I was aware of at the time) PEPs.
The PR was ignored here so I closed it.

I have it running in my fork in the main branch if you want to have a look. :-)